[Look&Feel] Revert tooltip addition for navigation menu #7493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Dong <danieldong51@gmail.com>
Signed-off-by: Dan Dong <danieldong51@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7493 +/- ##
==========================================
- Coverage 64.13% 64.11% -0.02%
==========================================
Files 3616 3616
Lines 78730 78759 +29
Branches 12446 12453 +7
==========================================
+ Hits 50490 50496 +6
- Misses 25187 25206 +19
- Partials 3053 3057 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danieldong51
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi and
sejli
as code owners
Signed-off-by: Dan Dong <danieldong51@gmail.com>
ashwin-pc
added
backport 2.x
v2.16.0
backport 2.16
look & feel
virajsanghvi
previously approved these changes
Jul 25, 2024
| @@ -205,4 +206,17 @@ describe('Header', () => { | |||
|
|
|||
| expect(component.find('.header__toggleNavButtonSection').exists()).toBeFalsy(); | |||
| }); | |||
|
|
|||
| it('toggles primary navigation menu when clicked', () => { | |||
There was a problem hiding this comment.
was this just for coverage?
|
@danieldong51 since this change reverts a change that happened in the same release, we dont need a new changeset file, rather we should either update or remove the old changeset here. |
github-actions
bot
added
the
Skip-Changelog
virajsanghvi
approved these changes
Jul 26, 2024
74 tasks
zhongnansu
approved these changes
Jul 26, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
(cherry picked from commit 5a849b0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
(cherry picked from commit 5a849b0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
danieldong51
added a commit
to danieldong51/OpenSearch-Dashboards
that referenced
this pull request
Jul 26, 2024
…roject#7493) (cherry picked from commit 5a849b0)
7 tasks
danieldong51
added a commit
to danieldong51/OpenSearch-Dashboards
that referenced
this pull request
Jul 26, 2024
…roject#7493) (cherry picked from commit 5a849b0)
danieldong51
added a commit
to danieldong51/OpenSearch-Dashboards
that referenced
this pull request
Jul 26, 2024
…roject#7493) (cherry picked from commit 5a849b0)
7 tasks
paulstn
pushed a commit
to paulstn/OpenSearch-Dashboards
that referenced
this pull request
Jul 26, 2024
zhongnansu
pushed a commit
that referenced
this pull request
Jul 29, 2024
…ation menu (#7524) * [Look&Feel] Revert tooltip addition for navigation menu (#7493) (cherry picked from commit 5a849b0) * Updated functional test Signed-off-by: Dan Dong <danieldong51@gmail.com> --------- Signed-off-by: Dan Dong <danieldong51@gmail.com> Co-authored-by: Viraj Sanghvi <virajs@amazon.com>
zhongnansu
pushed a commit
that referenced
this pull request
Jul 29, 2024
…gation menu (#7525) * [Look&Feel] Revert tooltip addition for navigation menu (#7493) (cherry picked from commit 5a849b0) * Updated functional test Signed-off-by: Dan Dong <danieldong51@gmail.com> --------- Signed-off-by: Dan Dong <danieldong51@gmail.com> Co-authored-by: Viraj Sanghvi <virajs@amazon.com>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts addition of EuiTooltip for header menu button, due to bug where tooltip will always pop up when menu is closed or user navigates to another page.
Issues Resolved
#7483
Screenshot
Changelog
Check List
yarn test:jestyarn test:jest_integration