-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provide new embeddable option to hide embeddable panel action button #7503
feat: provide new embeddable option to hide embeddable panel action button #7503
Conversation
…utton Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7503 +/- ##
==========================================
- Coverage 63.98% 63.66% -0.32%
==========================================
Files 3598 3632 +34
Lines 78322 80070 +1748
Branches 12352 12688 +336
==========================================
+ Hits 50111 50978 +867
- Misses 25189 25986 +797
- Partials 3022 3106 +84
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@AMoo-Miki Thanks for the feedback, PR updated, could take a another look please? |
…utton (#7503) * feat: provide new embeddable option to hide embeddable panel action button Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * Changeset file for PR #7503 created/updated * cleanup unnecessary getInput() calls Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 1bf63e3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…utton (#7503) (#7676) * feat: provide new embeddable option to hide embeddable panel action button * Changeset file for PR #7503 created/updated * cleanup unnecessary getInput() calls --------- (cherry picked from commit 1bf63e3) Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Similar to the existing options
hidePanelTitles
which hide embeddable panel titles, this PR introduced a new optionhidePanelActions
to hide the embeddable action button, this is useful for embeddable panels that don't have action, right now, action button always shows even when there was no action:With this PR, it's possible to hide the action button by specifying
{hidePanelActions: true}
in embeddable inputDescription
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration