Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide new embeddable option to hide embeddable panel action button #7503

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Jul 26, 2024

Similar to the existing options hidePanelTitles which hide embeddable panel titles, this PR introduced a new option hidePanelActions to hide the embeddable action button, this is useful for embeddable panels that don't have action, right now, action button always shows even when there was no action:

image

With this PR, it's possible to hide the action button by specifying {hidePanelActions: true} in embeddable input

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

  • feat: provide new embeddable option to hide embeddable panel action button

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…utton

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.66%. Comparing base (5ee9b69) to head (70ce43f).
Report is 66 commits behind head on main.

Files Patch % Lines
...s/embeddable/public/lib/panel/embeddable_panel.tsx 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7503      +/-   ##
==========================================
- Coverage   63.98%   63.66%   -0.32%     
==========================================
  Files        3598     3632      +34     
  Lines       78322    80070    +1748     
  Branches    12352    12688     +336     
==========================================
+ Hits        50111    50978     +867     
- Misses      25189    25986     +797     
- Partials     3022     3106      +84     
Flag Coverage Δ
Linux_1 30.54% <0.00%> (-0.54%) ⬇️
Linux_2 55.58% <ø> (-0.01%) ⬇️
Linux_3 40.58% <83.33%> (-0.72%) ⬇️
Linux_4 31.31% <91.66%> (-0.21%) ⬇️
Windows_1 30.56% <0.00%> (-0.54%) ⬇️
Windows_2 55.53% <ø> (+<0.01%) ⬆️
Windows_3 40.57% <83.33%> (-0.72%) ⬇️
Windows_4 31.31% <91.66%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SuZhou-Joe
SuZhou-Joe previously approved these changes Aug 7, 2024
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@ruanyl
Copy link
Member Author

ruanyl commented Aug 7, 2024

@AMoo-Miki Thanks for the feedback, PR updated, could take a another look please?

@AMoo-Miki AMoo-Miki merged commit 1bf63e3 into opensearch-project:main Aug 10, 2024
70 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 10, 2024
…utton (#7503)

* feat: provide new embeddable option to hide embeddable panel action button

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* Changeset file for PR #7503 created/updated

* cleanup unnecessary getInput() calls

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 1bf63e3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Aug 12, 2024
…utton (#7503) (#7676)

* feat: provide new embeddable option to hide embeddable panel action button



* Changeset file for PR #7503 created/updated

* cleanup unnecessary getInput() calls



---------



(cherry picked from commit 1bf63e3)

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants