[Backport 2.16] [Workspace] refactor saved object client addToWorkspaces and deleteFromWorkspaces function params structure #7519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…omWorkspaces function params structure (#7484) * update saved object client function params structure Signed-off-by: tygao <tygao@amazon.com> * delete options workspace field Signed-off-by: tygao <tygao@amazon.com> * delete options workspace field Signed-off-by: tygao <tygao@amazon.com> * delete workspace in create Signed-off-by: tygao <tygao@amazon.com> * Update src/core/server/saved_objects/service/saved_objects_client.ts Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Tianyu Gao <tygao@amazon.com> * Update src/core/server/saved_objects/service/saved_objects_client.ts Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Tianyu Gao <tygao@amazon.com> * update type Signed-off-by: tygao <tygao@amazon.com> * update params Signed-off-by: tygao <tygao@amazon.com> * remove workspace field in overwrite create Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: Tianyu Gao <tygao@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 2268738) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi and
sejli
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.16 #7519 +/- ##
==========================================
- Coverage 64.21% 64.20% -0.01%
==========================================
Files 3615 3615
Lines 78748 78752 +4
Branches 12443 12446 +3
==========================================
+ Hits 50565 50566 +1
+ Misses 25177 25133 -44
- Partials 3006 3053 +47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Jul 26, 2024
ZilongX
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2268738 from #7484.