Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[navigation]fix: add sample data to left navigation #7613

Merged
merged 3 commits into from
Aug 2, 2024
Merged

[navigation]fix: add sample data to left navigation #7613

merged 3 commits into from
Aug 2, 2024

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Aug 2, 2024 •
edited
Loading

Description

We lost sample data in the design of new left navigation and this PR is trying to bring it back because import sample data is a very useful feature in OSD to quickly setup some dashboards and visualizations.

Issues Resolved

Screenshot

Before fix

image

After fix

image
image
image
image
image

Testing the changes

  • Go to advanced settings and turn on new home page feature flag.
  • Find the entry in all of the use cases.

Changelog

  • fix: [navigation] add sample data to left navigation

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Aug 2, 2024
@opensearch-changeset-bot
Changeset file for PR opensearch-project#7613 created/updated
bef51e6
@SuZhou-Joe SuZhou-Joe force-pushed the feature/add-sample-data branch from bef51e6 to c39bae4 Compare August 2, 2024 11:20
@SuZhou-Joe SuZhou-Joe changed the title [navigation]feat: add sample data to left navigation [navigation]fix: add sample data to left navigation Aug 2, 2024
@SuZhou-Joe SuZhou-Joe added the bug Something isn't working label Aug 2, 2024
@SuZhou-Joe
feat: add sample data to left navigation
fabffad 
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
@codecov Codecov
Copy link

codecov bot commented Aug 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.65%. Comparing base (14c71c7) to head (fabffad).

Files Patch % Lines
src/plugins/home/public/plugin.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7613      +/-   ##
==========================================
- Coverage   63.65%   63.65%   -0.01%     
==========================================
  Files        3632     3632              
  Lines       80056    80060       +4     
  Branches    12682    12683       +1     
==========================================
+ Hits        50962    50963       +1     
- Misses      25990    25991       +1     
- Partials     3104     3106       +2
Flag Coverage Δ
Linux_1 30.55% <0.00%> (-0.01%) ⬇️
Linux_2 55.58% <ø> (ø)
Linux_3 40.55% <0.00%> (-0.01%) ⬇️
Linux_4 31.30% <75.00%> (+<0.01%) ⬆️
Windows_1 30.57% <0.00%> (-0.01%) ⬇️
Windows_2 55.53% <ø> (ø)
Windows_3 40.56% <0.00%> (-0.01%) ⬇️
Windows_4 31.30% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruanyl
ruanyl approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@ruanyl ruanyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@BionIT BionIT merged commit 352d2e9 into opensearch-project:main Aug 2, 2024
67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 2, 2024
@github-actions @opensearch-changeset-bot
[navigation]fix: add sample data to left navigation (#7613)
79dec76 
* feat: add sample data to left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7613 created/updated

* feat: add sample data to left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 352d2e9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 2, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 2, 2024
@github-actions @opensearch-changeset-bot
[navigation]fix: add sample data to left navigation (#7613)
137b103 
* feat: add sample data to left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7613 created/updated

* feat: add sample data to left navigation

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 352d2e9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 2, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Aug 2, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[navigation]fix: add sample data to left navigation (#7613) (#7614)
c11364e 
* feat: add sample data to left navigation



* Changeset file for PR #7613 created/updated

* feat: add sample data to left navigation



---------



(cherry picked from commit 352d2e9)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 2, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[navigation]fix: add sample data to left navigation (#7613) (#7615)
4b8826e 
* feat: add sample data to left navigation



* Changeset file for PR #7613 created/updated

* feat: add sample data to left navigation



---------



(cherry picked from commit 352d2e9)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BionIT BionIT BionIT approved these changes

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
all-star-contributor backport 2.x backport 2.16 bug Something isn't working navigation v2.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SuZhou-Joe @ruanyl @BionIT