Make main page primary dashboard card logo and title configurable #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add one new config branding.loadingLogoUrl for making loading page logo configurable. URL can be in svg and gif format. If no loading logo is found, the static logo with a horizontal bar loading bar will be shown. If logo is also not found, the default OpenSearch loading logo and spinner will be shown. Signed-off-by: Abby Hu <abigailhu2000@gmail.com>
Dashboard primary card logo can be customized by config branding.smallLogoUrl and title can be customized by branding.title. Also add title validation function so the title length can only be between 1 - 36. Modify some legacy validation schema so user input empty string will also render default OpenSearch branding. Signed-off-by: Abby Hu <abigailhu2000@gmail.com>
|
✅ DCO Check Passed ee88a6e |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
US4: User can configure logo and title in the opensearch_dashboards.yml and see it in the application at run time for the primary dashboard card on the main page.
Requirement:
User need to input a valid URL for opensearchDashboards.branding.smallLogoUrl and a valid string for opensearchDashboards.branding.title in the opensearch_dashboards.yml file.
Details:
Related Project Card:
https://github.com/abbyhu2000/OpenSearch-Dashboards/projects/1#card-68050198
Signed-off-by: Abby Hu abigailhu2000@gmail.com
Check List