-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow screenTitle
to be present when SearchBar is not in Application header
#7721
Allow screenTitle
to be present when SearchBar is not in Application header
#7721
Conversation
Signed-off-by: Miki <miki@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7721 +/- ##
==========================================
- Coverage 63.82% 63.82% -0.01%
==========================================
Files 3643 3651 +8
Lines 80644 80953 +309
Branches 12822 12886 +64
==========================================
+ Hits 51469 51665 +196
- Misses 26039 26124 +85
- Partials 3136 3164 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Build and Verify CI 1 failure is related to a bad PR being merged: #7699 |
…n header (#7721) * Allow `screenTitle` to be present when SearchBar is not Signed-off-by: Miki <miki@amazon.com> * Changeset file for PR #7721 created/updated --------- Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 577b3ec) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…n header (#7721) (#7722) * Allow `screenTitle` to be present when SearchBar is not * Changeset file for PR #7721 created/updated --------- (cherry picked from commit 577b3ec) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
Allow
screenTitle
to be present when SearchBar is not in Application headerChangelog
screenTitle
to be present when SearchBar is not in Application headerCheck List
yarn test:jest
yarn test:jest_integration