Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify TopNavControlDescriptionData to to be followed by links #7723

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

Description

Simplify TopNavControlDescriptionData to to be followed by links

Changelog

  • feat: Simplify TopNavControlDescriptionData to to be followed by links

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 63.82%. Comparing base (577b3ec) to head (8256b23).

Files Patch % Lines
...ation/public/top_nav_menu/top_nav_control_item.tsx 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7723   +/-   ##
=======================================
  Coverage   63.82%   63.82%           
=======================================
  Files        3651     3651           
  Lines       80953    80955    +2     
  Branches    12886    12887    +1     
=======================================
+ Hits        51665    51667    +2     
  Misses      26124    26124           
  Partials     3164     3164           
Flag Coverage Δ
Linux_2 55.84% <ø> (ø)
Linux_3 40.41% <0.00%> (+<0.01%) ⬆️
Linux_4 31.30% <0.00%> (-0.01%) ⬇️
Windows_1 30.03% <0.00%> (-0.01%) ⬇️
Windows_2 55.80% <ø> (ø)
Windows_3 40.41% <0.00%> (-0.01%) ⬇️
Windows_4 31.30% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMoo-Miki
Copy link
Collaborator Author

Build and Verify CI 1 failure is related to a bad PR being merged: #7699

Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming test failures are unrelated

@AMoo-Miki AMoo-Miki merged commit d447c5d into opensearch-project:main Aug 15, 2024
65 of 67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 15, 2024
…7723)

* Simplify `TopNavControlDescriptionData` to to be followed by links

Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR #7723 created/updated

---------

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit d447c5d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki pushed a commit that referenced this pull request Aug 19, 2024
…7723) (#7724)

* Simplify `TopNavControlDescriptionData` to to be followed by links



* Changeset file for PR #7723 created/updated

---------



(cherry picked from commit d447c5d)

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants