Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discover-2.0] update interfaces and services for query, data, languages #7731

Merged
merged 13 commits into from
Aug 27, 2024

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Aug 16, 2024

Description

This PR stabilizes the Multi-Query Language (MQL), and Multiple-Data-Sources (MDS) features by updating types to utilize a generic structure, abstracting data querying, and introducing a Language service. These changes aim to resolve conflicts in data source definitions across different projects and provide a flexible framework for handling various data structures.

Notes

  • The commits on this branch were reviewed individually.
  • The size of this PR is primarily due to cleanup and consolidation efforts.

This PR represents a significant step towards a more flexible and extensible multi-query language system in OpenSearch Dashboards.

Key Changes

  1. Generic Data Structure: Introduced a flexible DataStructure interface that can represent various data hierarchies without hard-coding specific fields.

  2. Abstract Data Querying: Implemented a system where actual data querying is left to the project or developer to implement, allowing for diverse opinions and implementations.

  3. Language Service: Added a Language service that registers more closely with the query object, improving the flow of queries through the application.

  4. Consolidation: Cleaned up and consolidated existing code, resulting in a large PR despite individual commits being reviewed separately.

DataStructure Interface

The core of this update is the DataStructure interface:

export interface DataStructure {
  id: string;
  title: string;
  type: string;
  parent?: DataStructure;
  children?: DataStructure[];
  hasNext?: boolean;
  columnHeader?: string;
  meta?: DataStructureMeta;
}

This interface allows for representation of various data hierarchies, such as OpenSearch clusters, indices, or even complex nested structures like S3 data sources.

Benefits

  • Flexibility: Developers can populate the DataStructure with values specific to their data source types without modifying the core interface.
  • Consistency: Standardized structure for representing different data sources and their hierarchies.
  • Extensibility: Easy to add new data source types without changing the underlying system.
    Improved Query Handling: The Language service allows for better integration of queries with different data structures.

Scope

Currently, these changes are only enabled for the Discover application. They lay the groundwork for potential future expansion to other parts of the system.

Screenshot

Testing the changes

local and CI

Changelog

  • refactor: Multi-datasources and multi-query languages features to use generic structured types, abstract data querying, and the language service

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 7731.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

Copy link
Contributor

❌ Changeset File Not Added Yet

Please ensure manual commit for changeset file 7731.yml under folder changelogs/fragments to complete this PR. File still missing.

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 30.96774% with 214 lines in your changes missing coverage. Please review.

Project coverage is 64.16%. Comparing base (6931a41) to head (caf949c).
Report is 147 commits behind head on main.

Files with missing lines Patch % Lines
.../query_string/language_service/language_service.ts 21.27% 37 Missing ⚠️
...y_string/dataset_service/lib/index_pattern_type.ts 6.45% 29 Missing ⚠️
...ry/query_string/dataset_service/dataset_service.ts 18.18% 24 Missing and 3 partials ⚠️
...ery/query_string/dataset_service/lib/index_type.ts 13.79% 25 Missing ⚠️
.../public/query/query_string/query_string_manager.ts 50.00% 13 Missing and 1 partial ⚠️
...c/plugins/data/common/datasets/_structure_cache.ts 0.00% 11 Missing ⚠️
...public/utils/state_management/redux_persistence.ts 23.07% 9 Missing and 1 partial ⚠️
...blic/ui/search_bar/lib/use_query_string_manager.ts 0.00% 9 Missing ⚠️
src/plugins/data/public/search/search_service.ts 0.00% 8 Missing ⚠️
...c/plugins/data/public/ui/search_bar/search_bar.tsx 36.36% 6 Missing and 1 partial ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7731      +/-   ##
==========================================
+ Coverage   63.86%   64.16%   +0.30%     
==========================================
  Files        3665     3659       -6     
  Lines       81441    80796     -645     
  Branches    12994    12866     -128     
==========================================
- Hits        52010    51846     -164     
+ Misses      26243    25770     -473     
+ Partials     3188     3180       -8     
Flag Coverage Δ
Linux_1 30.30% <12.85%> (+0.10%) ⬆️
Linux_2 55.89% <14.28%> (+0.01%) ⬆️
Linux_3 40.67% <31.98%> (+0.27%) ⬆️
Linux_4 31.46% <12.69%> (+0.09%) ⬆️
Windows_1 30.32% <12.85%> (+0.08%) ⬆️
Windows_2 55.85% <14.28%> (+0.01%) ⬆️
Windows_3 40.67% <31.98%> (+0.27%) ⬆️
Windows_4 31.46% <12.69%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abbyhu2000 abbyhu2000 force-pushed the feature/discover-interfaces branch from 04b4784 to 21604e8 Compare August 19, 2024 22:45
@ashwin-pc ashwin-pc marked this pull request as ready for review August 26, 2024 19:58
@kavilla kavilla changed the title Initial updates to new interfaces Discover expects [discover-2.0] update interfaces and services for query, data, languages Aug 27, 2024
@kavilla kavilla dismissed sejli’s stale review August 27, 2024 10:09

The merge-base changed after approval.

abbyhu2000
abbyhu2000 previously approved these changes Aug 27, 2024
@kavilla kavilla dismissed abbyhu2000’s stale review August 27, 2024 10:14

The merge-base changed after approval.

@kavilla
Copy link
Member Author

kavilla commented Aug 27, 2024

I dont know why github seems to be dismissing this PR approvals. It's actually really annoying. I'm not pushing any changes and I'm not dismissing any of the reviews.

kavilla and others added 13 commits August 27, 2024 10:24
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
* Move dataset location

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update interfaces

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Update src/plugins/data/common/datasets/types.ts

Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
* dataset handler and move manager

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Adds new Data selector

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

fixes loading state

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* start wiring into the selector

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

no more white screen

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

updating handler

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

rendering data

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

data structures working ok

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

need to add datasets

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

clean up

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

deleted unneeded types

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* still working on the data structure and field

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* still not working. the leaf logic isnt right i believe

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* indices

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* pushing datasets

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix index pattern

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fixes with column

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* working creation step

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* get dataset from state in use index pattern

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* dataset selector working

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update ppl interceptor

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* add dataset service

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* language service

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* wired up but the dataset is off

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Address review comments

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* ppl query

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* dql and lucene working again

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix issue that would deselect dataset

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* language switches and sets the query correctly

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* upating query

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix the styling a little

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* little bit width

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* submit on update

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix sql

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* ppl working better

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* need to still fix the aggregations

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* gotta fix the aggs and still need to update dql lucene dataset

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* use patch

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Metadata slice

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* index pattern updates

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* types and datasource prepend

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
* progress

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* get rid of setting class

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* register editor inside language

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* address commits

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* address more comments

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* change editor

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
* update manager

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Extension passing

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* mock getIndexPatterns

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
* Fix Nav Bar layout in New Discover

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

* Changeset file for PR #7853 created/updated

---------

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
* Updating mocks still

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Keep fixing mocks

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update to not use getter

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix the query being updated twice

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update snapshot

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla kavilla force-pushed the feature/discover-interfaces branch from c40dcab to caf949c Compare August 27, 2024 10:25
@kavilla kavilla merged commit 1976ecf into main Aug 27, 2024
53 of 55 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7731-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1976ecfd223bb8cb2462b2779d1b7af97016c476
# Push it to GitHub
git push --set-upstream origin backport/backport-7731-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7731-to-2.x.

kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this pull request Aug 27, 2024
…ges (opensearch-project#7731)

* Initial updates to new interfaces Discover expects

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* [discover] update interfaces and move dataset manager (opensearch-project#7745)

* Move dataset location

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update interfaces

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Update src/plugins/data/common/datasets/types.ts

Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com>

* fix rebase errors

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [discover] update interfaces and selector (opensearch-project#7835)

* dataset handler and move manager

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Adds new Data selector

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

fixes loading state

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* start wiring into the selector

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

no more white screen

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

updating handler

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

rendering data

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

data structures working ok

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

need to add datasets

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

clean up

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

deleted unneeded types

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* still working on the data structure and field

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* still not working. the leaf logic isnt right i believe

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* indices

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* pushing datasets

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix index pattern

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fixes with column

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* working creation step

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* get dataset from state in use index pattern

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* dataset selector working

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update ppl interceptor

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* add dataset service

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* language service

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* wired up but the dataset is off

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Address review comments

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* ppl query

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* dql and lucene working again

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix issue that would deselect dataset

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* language switches and sets the query correctly

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* upating query

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix the styling a little

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* little bit width

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* submit on update

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix sql

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* ppl working better

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* need to still fix the aggregations

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* gotta fix the aggs and still need to update dql lucene dataset

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* use patch

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Metadata slice

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* index pattern updates

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* types and datasource prepend

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Use language service to render query editor (opensearch-project#7848)

* progress

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* get rid of setting class

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* register editor inside language

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* address commits

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* address more comments

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* change editor

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* minor fixes (opensearch-project#7850)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [discover] Updates to mocks for tests and ci (opensearch-project#7852)

* update manager

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Extension passing

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* mock getIndexPatterns

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* include create and save

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Fix Nav Bar layout in New Discover (opensearch-project#7853)

* Fix Nav Bar layout in New Discover

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

* Changeset file for PR opensearch-project#7853 created/updated

---------

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* [discover] keep fixing mocks (opensearch-project#7855)

* Updating mocks still

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Keep fixing mocks

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update to not use getter

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix the query being updated twice

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update snapshot

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix remaining failures

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* manual changelog

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update snapshot

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com>
Co-authored-by: abbyhu2000 <abigailhu2000@gmail.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 1976ecf)
ashwin-pc pushed a commit that referenced this pull request Aug 27, 2024
…ges (#7731) (#7863)

* Initial updates to new interfaces Discover expects

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* [discover] update interfaces and move dataset manager (#7745)

* Move dataset location

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update interfaces

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Update src/plugins/data/common/datasets/types.ts

Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com>

* fix rebase errors

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [discover] update interfaces and selector (#7835)

* dataset handler and move manager

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Adds new Data selector

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

fixes loading state

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* start wiring into the selector

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

no more white screen

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

updating handler

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

rendering data

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

data structures working ok

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

need to add datasets

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

clean up

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

deleted unneeded types

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* still working on the data structure and field

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* still not working. the leaf logic isnt right i believe

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* indices

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* pushing datasets

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix index pattern

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fixes with column

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* working creation step

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* get dataset from state in use index pattern

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* dataset selector working

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update ppl interceptor

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* add dataset service

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* language service

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* wired up but the dataset is off

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Address review comments

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* ppl query

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* dql and lucene working again

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix issue that would deselect dataset

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* language switches and sets the query correctly

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* upating query

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix the styling a little

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* little bit width

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* submit on update

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix sql

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* ppl working better

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* need to still fix the aggregations

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* gotta fix the aggs and still need to update dql lucene dataset

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* use patch

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Metadata slice

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* index pattern updates

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* types and datasource prepend

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Use language service to render query editor (#7848)

* progress

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* get rid of setting class

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* register editor inside language

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* address commits

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* address more comments

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* change editor

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* minor fixes (#7850)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [discover] Updates to mocks for tests and ci (#7852)

* update manager

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Extension passing

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* mock getIndexPatterns

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* include create and save

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Fix Nav Bar layout in New Discover (#7853)

* Fix Nav Bar layout in New Discover

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

* Changeset file for PR #7853 created/updated

---------

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* [discover] keep fixing mocks (#7855)

* Updating mocks still

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Keep fixing mocks

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update to not use getter

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix the query being updated twice

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update snapshot

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* fix remaining failures

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* manual changelog

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* update snapshot

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc1993@gmail.com>
Co-authored-by: abbyhu2000 <abigailhu2000@gmail.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Suchit Sahoo <38322563+LDrago27@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 1976ecf)
@AMoo-Miki
Copy link
Collaborator

Manually backported with #7863

@kavilla kavilla deleted the feature/discover-interfaces branch September 13, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants