-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add V9 Theme #7757
feat: Add V9 Theme #7757
Conversation
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
@import "../../../node_modules/@elastic/eui/src/global_styling/functions/index"; | ||
@import "../../../node_modules/@elastic/eui/src/global_styling/variables/index"; | ||
@import "../../../node_modules/@elastic/eui/src/global_styling/mixins/index"; | ||
|
||
// Configuration | ||
@import "global_styling/variables/index"; | ||
|
||
// Coreß | ||
@import "global_styling/mixins/index"; | ||
@import "global_styling/reset/index"; | ||
|
||
// Components | ||
@import "components/index"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: next theme also uses v7 dependencies - not sure why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way OUI is consumed is that v7 provides all of the defaults and other themes simply override what they want. In practice though, OUI themes already override everything so we shouldn't need this.
We will need to revisit this approach.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7757 +/- ##
==========================================
- Coverage 63.82% 63.82% -0.01%
==========================================
Files 3653 3653
Lines 81038 81047 +9
Branches 12903 12905 +2
==========================================
+ Hits 51726 51729 +3
- Misses 26138 26146 +8
+ Partials 3174 3172 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7757-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9d3ca7957a1c851d7b9a4fae8a2f1020a6c5fd9c
# Push it to GitHub
git push --set-upstream origin backport/backport-7757-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
* feat: Add V9 Theme --------- Signed-off-by: Viraj Sanghvi <virajs@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 9d3ca79)
* feat: Add V9 Theme --------- Signed-off-by: Viraj Sanghvi <virajs@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 9d3ca79)
Description
Adds v9 theme as preview
Notes:
Issues Resolved
N/A
Screenshot
Dashboards page:
Testing the changes
Validated can switch between themes in both admin and user control
Changelog
Check List
yarn test:jest
yarn test:jest_integration