Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add V9 Theme #7757

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Conversation

virajsanghvi
Copy link
Collaborator

@virajsanghvi virajsanghvi commented Aug 19, 2024

Description

Adds v9 theme as preview

Notes:

  • added dist/kui themes because they were there for the other themes (these are generated files by the build)
  • I used google's woff2 command line converter to convert ttf files to woff2
  • The theme is a work in progress we'll have more changes later this week

Issues Resolved

N/A

Screenshot

Dashboards page:

image

Testing the changes

Validated can switch between themes in both admin and user control

Changelog

  • feat: Add v9 theme (preview)

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Comment on lines +3 to +15
@import "../../../node_modules/@elastic/eui/src/global_styling/functions/index";
@import "../../../node_modules/@elastic/eui/src/global_styling/variables/index";
@import "../../../node_modules/@elastic/eui/src/global_styling/mixins/index";

// Configuration
@import "global_styling/variables/index";

// Coreß
@import "global_styling/mixins/index";
@import "global_styling/reset/index";

// Components
@import "components/index";
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: next theme also uses v7 dependencies - not sure why

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way OUI is consumed is that v7 provides all of the defaults and other themes simply override what they want. In practice though, OUI themes already override everything so we shouldn't need this.

We will need to revisit this approach.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.82%. Comparing base (9a84202) to head (7b94652).
Report is 185 commits behind head on main.

Files with missing lines Patch % Lines
src/core/server/ui_settings/settings/theme.ts 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7757      +/-   ##
==========================================
- Coverage   63.82%   63.82%   -0.01%     
==========================================
  Files        3653     3653              
  Lines       81038    81047       +9     
  Branches    12903    12905       +2     
==========================================
+ Hits        51726    51729       +3     
- Misses      26138    26146       +8     
+ Partials     3174     3172       -2     
Flag Coverage Δ
Linux_1 30.05% <27.27%> (+<0.01%) ⬆️
Linux_2 55.87% <90.90%> (+0.01%) ⬆️
Linux_3 40.42% <27.27%> (-0.01%) ⬇️
Linux_4 31.28% <27.27%> (+<0.01%) ⬆️
Windows_1 30.07% <27.27%> (-0.02%) ⬇️
Windows_2 55.82% <90.90%> (+0.01%) ⬆️
Windows_3 40.43% <27.27%> (?)
Windows_4 31.28% <27.27%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
@virajsanghvi virajsanghvi added v2.17.0 look & feel Look and Feel Improvements labels Aug 19, 2024
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
@virajsanghvi virajsanghvi merged commit 9d3ca79 into opensearch-project:main Aug 20, 2024
66 of 67 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7757-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9d3ca7957a1c851d7b9a4fae8a2f1020a6c5fd9c
# Push it to GitHub
git push --set-upstream origin backport/backport-7757-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7757-to-2.x.

virajsanghvi added a commit to virajsanghvi/OpenSearch-Dashboards that referenced this pull request Aug 20, 2024
* feat: Add V9 Theme
---------

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 9d3ca79)
virajsanghvi added a commit to virajsanghvi/OpenSearch-Dashboards that referenced this pull request Aug 20, 2024
* feat: Add V9 Theme
---------

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 9d3ca79)
virajsanghvi added a commit that referenced this pull request Aug 20, 2024
* feat: Add V9 Theme
---------

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 9d3ca79)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants