Add iconGap to TopNavControlButtonData abd TopNavControlLinkData
#7799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
requested review from
ananzh,
kavilla,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
❌ Entry Too LongEntry is 104 characters long, which is 4 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7799 +/- ##
==========================================
- Coverage 63.80% 63.80% -0.01%
==========================================
Files 3656 3656
Lines 81205 81210 +5
Branches 12949 12950 +1
==========================================
+ Hits 51809 51812 +3
- Misses 26215 26217 +2
Partials 3181 3181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ruanyl
approved these changes
Aug 22, 2024
sejli
approved these changes
Aug 22, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
#7799) * Bump OUI to 1.11.0 Signed-off-by: Miki <miki@amazon.com> * Update snapshots for OUI 1.11.0 Signed-off-by: Miki <miki@amazon.com> * Add `iconGap` to `TopNavControlButtonData` abd `TopNavControlLinkData` Signed-off-by: Miki <miki@amazon.com> * Changeset file for PR #7799 created/updated * Changeset file for PR #7799 created/updated --------- Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 3a41f7b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Aug 22, 2024
#7799) (#7800) * Bump OUI to 1.11.0 * Update snapshots for OUI 1.11.0 * Add `iconGap` to `TopNavControlButtonData` abd `TopNavControlLinkData` * Changeset file for PR #7799 created/updated * Changeset file for PR #7799 created/updated --------- (cherry picked from commit 3a41f7b) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
iconGaptoTopNavControlButtonDataandTopNavControlLinkDataAlso:
Changelog
TopNavControlButtonDataandTopNavControlLinkDatawithtarget: '_blank'iconGaptoTopNavControlButtonDataandTopNavControlLinkDataCheck List
yarn test:jestyarn test:jest_integration