-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CVE-2017-16100] Use a patched version of dns-sync
#7811
Conversation
868f9a2
to
01007c1
Compare
460c434
to
4a2328f
Compare
@@ -190,7 +190,7 @@ | |||
"core-js": "^3.6.5", | |||
"deep-freeze-strict": "^1.1.1", | |||
"del": "^6.1.1", | |||
"dns-sync": "^0.2.1", | |||
"dns-sync": "npm:@amoo-miki/dns-sync@^0.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AMoo-Miki I have been thinking why not publishing under @opensearch-project
? Or do we have the plan to move these forked packages to @opensearch-project
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we could, publishing them under the project name would create an expectation of ownership and support which we don't have the bandwidth for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the only concern is it might not be scale to put on personal repo just for one fix. but it should be ok if we don't have other option.
@@ -190,7 +190,7 @@ | |||
"core-js": "^3.6.5", | |||
"deep-freeze-strict": "^1.1.1", | |||
"del": "^6.1.1", | |||
"dns-sync": "^0.2.1", | |||
"dns-sync": "npm:@amoo-miki/dns-sync@^0.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the only concern is it might not be scale to put on personal repo just for one fix. but it should be ok if we don't have other option.
@@ -0,0 +1,2 @@ | |||
security: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not related to this PR.
in 2.14 we proved we could generate release note without changelog file. the maintainers should consider deprecate the needs of this file and simplify the contribution process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the auto-generated one.
There are many [abandoned] packages that use my patched releases :) |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-1.3
# Create a new branch
git switch --create backport/backport-7811-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dcd170aa7d6ee0d09bbd0f8d397a93e5a73d8f67
# Push it to GitHub
git push --set-upstream origin backport/backport-7811-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-1.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7811-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dcd170aa7d6ee0d09bbd0f8d397a93e5a73d8f67
# Push it to GitHub
git push --set-upstream origin backport/backport-7811-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
* [CVE-2017-16100] Use a patched version of `dns-sync` Signed-off-by: Miki <miki@amazon.com> * Changeset file for PR #7811 created/updated --------- Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com> (cherry picked from commit dcd170a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-1.3
# Create a new branch
git switch --create backport/backport-7811-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dcd170aa7d6ee0d09bbd0f8d397a93e5a73d8f67
# Push it to GitHub
git push --set-upstream origin backport/backport-7811-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-1.3 Then, create a pull request where the |
Manually backported to 1.3. |
* [CVE-2017-16100] Use a patched version of `dns-sync` * Changeset file for PR #7811 created/updated --------- (cherry picked from commit dcd170a) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
* [CVE-2017-16100] Use a patched version of `dns-sync` * Changeset file for PR #7811 created/updated --------- (cherry picked from commit dcd170a) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com> (cherry picked from commit a8fca1c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…8145) * [CVE-2017-16100] Use a patched version of `dns-sync` * Changeset file for PR #7811 created/updated --------- (cherry picked from commit dcd170a) (cherry picked from commit a8fca1c) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
Description
[CVE-2017-16100] Use a patched version of
dns-sync
dns-sync
The library hasn't been updated in years. Even though an upstream PR was created, due to the criticality of the CVE, until upstream package is updated a patched version is employed.
Changelog
dns-sync
dependencyCheck List
yarn test:jest
yarn test:jest_integration