-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[navigation] Add workspace icon to left nav / workspace picker menu / home page. #7823
[navigation] Add workspace icon to left nav / workspace picker menu / home page. #7823
Conversation
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
…ce is disabled Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
66acdd9
to
d2cccf3
Compare
d2cccf3
to
c8a5819
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7823 +/- ##
=======================================
Coverage 61.01% 61.02%
=======================================
Files 3688 3688
Lines 87221 87232 +11
Branches 13417 13423 +6
=======================================
+ Hits 53219 53229 +10
Misses 30775 30775
- Partials 3227 3228 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
src/core/public/chrome/ui/header/collapsible_nav_group_enabled_top.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/use_case_overview/setup_overview.scss
Show resolved
Hide resolved
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7823-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1974ca1b1f0ac01f5ac94bb52b8c68215b94e320
# Push it to GitHub
git push --set-upstream origin backport/backport-7823-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7823-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1974ca1b1f0ac01f5ac94bb52b8c68215b94e320
# Push it to GitHub
git push --set-upstream origin backport/backport-7823-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
… home page. (opensearch-project#7823) * feat: show workspace picker content in left nav Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: finish picker content Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: finish picker content Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: only register index patterns to settings and setup when workspace is disabled Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: put discover 2.0 behind discover Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: improve test coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: merge conflict Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code based on comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code based on comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize filter code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add new icon to left navigation and workspace picker menu Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change use case card in home Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize alignment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR opensearch-project#7823 created/updated * feat: alignment optimize Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use new icons in workspace picker Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize color Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: increase test coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Add workspace icon in workspace creator (#19) Signed-off-by: Lin Wang <wonglam@amazon.com> * fix: fatal error when visibleUseCases is empty Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit 1974ca1)
… home page. (#7823) (#7994) * feat: show workspace picker content in left nav Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: finish picker content Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: finish picker content Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: only register index patterns to settings and setup when workspace is disabled Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: put discover 2.0 behind discover Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: improve test coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: merge conflict Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code based on comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code based on comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize filter code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add new icon to left navigation and workspace picker menu Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change use case card in home Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize alignment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7823 created/updated * feat: alignment optimize Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use new icons in workspace picker Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize color Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: increase test coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Add workspace icon in workspace creator (#19) Signed-off-by: Lin Wang <wonglam@amazon.com> * fix: fatal error when visibleUseCases is empty Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit 1974ca1)
… home page. (#7823) (#7994) * feat: show workspace picker content in left nav Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: finish picker content Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: finish picker content Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: only register index patterns to settings and setup when workspace is disabled Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: put discover 2.0 behind discover Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: improve test coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: merge conflict Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code based on comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code based on comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize filter code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add new icon to left navigation and workspace picker menu Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change use case card in home Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize alignment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7823 created/updated * feat: alignment optimize Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: use new icons in workspace picker Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize color Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: increase test coverage Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Add workspace icon in workspace creator (#19) Signed-off-by: Lin Wang <wonglam@amazon.com> * fix: fatal error when visibleUseCases is empty Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit 1974ca1) (cherry picked from commit cbdb0fd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
… home page. (#7823) (#7994) (#7995) * feat: show workspace picker content in left nav * fix: bootstrap error * fix: unit test error * feat: finish picker content * feat: finish picker content * feat: only register index patterns to settings and setup when workspace is disabled * fix: unit test * feat: put discover 2.0 behind discover * feat: add coverage * feat: improve test coverage * feat: merge conflict * feat: optimize code based on comment * feat: optimize code based on comment * feat: optimize filter code * feat: update * feat: add new icon to left navigation and workspace picker menu * feat: change use case card in home * feat: optimize alignment * Changeset file for PR #7823 created/updated * feat: alignment optimize * feat: use new icons in workspace picker * feat: optimize color * fix: unit test error * fix: unit test * fix: unit test * feat: increase test coverage * feat: remove useless code * Add workspace icon in workspace creator (#19) * fix: fatal error when visibleUseCases is empty --------- (cherry picked from commit 1974ca1) (cherry picked from commit cbdb0fd) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lin Wang <wonglam@amazon.com>
… home page. (#7823) (#7994) (#7995) * feat: show workspace picker content in left nav * fix: bootstrap error * fix: unit test error * feat: finish picker content * feat: finish picker content * feat: only register index patterns to settings and setup when workspace is disabled * fix: unit test * feat: put discover 2.0 behind discover * feat: add coverage * feat: improve test coverage * feat: merge conflict * feat: optimize code based on comment * feat: optimize code based on comment * feat: optimize filter code * feat: update * feat: add new icon to left navigation and workspace picker menu * feat: change use case card in home * feat: optimize alignment * Changeset file for PR #7823 created/updated * feat: alignment optimize * feat: use new icons in workspace picker * feat: optimize color * fix: unit test error * fix: unit test * fix: unit test * feat: increase test coverage * feat: remove useless code * Add workspace icon in workspace creator (#19) * fix: fatal error when visibleUseCases is empty --------- (cherry picked from commit 1974ca1) (cherry picked from commit cbdb0fd) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lin Wang <wonglam@amazon.com> (cherry picked from commit 4c64d81) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
… home page. (#7823) (#7994) (#7995) (#8038) * feat: show workspace picker content in left nav * fix: bootstrap error * fix: unit test error * feat: finish picker content * feat: finish picker content * feat: only register index patterns to settings and setup when workspace is disabled * fix: unit test * feat: put discover 2.0 behind discover * feat: add coverage * feat: improve test coverage * feat: merge conflict * feat: optimize code based on comment * feat: optimize code based on comment * feat: optimize filter code * feat: update * feat: add new icon to left navigation and workspace picker menu * feat: change use case card in home * feat: optimize alignment * Changeset file for PR #7823 created/updated * feat: alignment optimize * feat: use new icons in workspace picker * feat: optimize color * fix: unit test error * fix: unit test * fix: unit test * feat: increase test coverage * feat: remove useless code * Add workspace icon in workspace creator (#19) * fix: fatal error when visibleUseCases is empty --------- (cherry picked from commit 1974ca1) (cherry picked from commit cbdb0fd) (cherry picked from commit 4c64d81) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lin Wang <wonglam@amazon.com>
Description
We have icons for each user case and they should be displayed in home page / workspace picker menu and left nav. This PR is to adopt the icons in related places.
Issues Resolved
Screenshot
Use case icons in home page
Use case icons in workspace picker
Use case icons in left nav
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration