Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Page Header]Implement new page header for admin data sources page #7833

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

weiwang118
Copy link
Contributor

@weiwang118 weiwang118 commented Aug 23, 2024

Description

Implement new page header and Look&Feel UI changes for Admin->Data Sources page.

  • In data sources home page, change connection type tabs to button groups, and mount it on the top controls.
  • Mount create data source button and other action buttons on the top.
  • Remove duplicate head titles.
  • For connect s3 and connect prometheus page, change to one step page instead of previous two steps(Configure/Review) pages.
  • Make search bar, button, title to use small or compressed property.

Issues Resolved

Screenshot

New Page
Screenshot 2024-08-23 at 15 44 07
Screenshot 2024-08-23 at 15 44 47
Screenshot 2024-08-23 at 15 45 08
Screenshot 2024-08-23 at 15 46 02
Screenshot 2024-08-23 at 15 46 23
Screenshot 2024-08-23 at 15 46 39
Screenshot 2024-08-23 at 15 46 58
Screenshot 2024-08-23 at 15 47 19

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Wei Wang <weiwangv@amazon.com>
Copy link
Contributor

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

Copy link
Contributor

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

Copy link
Contributor

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "refactor". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

@github-actions github-actions bot added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Aug 24, 2024
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

Attention: Patch coverage is 58.97436% with 16 lines in your changes missing coverage. Please review.

Project coverage is 64.17%. Comparing base (452b65d) to head (32b0f5f).
Report is 12 commits behind head on main.

Files Patch % Lines
.../data_source_home_panel/data_source_home_panel.tsx 50.00% 3 Missing and 2 partials ⚠️
...source_management/public/components/breadcrumbs.ts 0.00% 0 Missing and 3 partials ⚠️
...tion/amazon_s3/configure_amazon_s3_data_source.tsx 50.00% 0 Missing and 3 partials ⚠️
...components/create_form/create_data_source_form.tsx 50.00% 0 Missing and 1 partial ⚠️
...source_creation_panel/create_data_source_panel.tsx 66.66% 0 Missing and 1 partial ⚠️
...figuration/configure_direct_query_data_sources.tsx 66.66% 1 Missing ⚠️
...on/prometheus/configure_prometheus_data_source.tsx 66.66% 0 Missing and 1 partial ⚠️
...ents/edit_data_source/components/header/header.tsx 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7833      +/-   ##
==========================================
+ Coverage   63.83%   64.17%   +0.34%     
==========================================
  Files        3661     3659       -2     
  Lines       81347    80811     -536     
  Branches    12978    12879      -99     
==========================================
- Hits        51926    51862      -64     
+ Misses      26235    25763     -472     
  Partials     3186     3186              
Flag Coverage Δ
Linux_1 30.30% <ø> (+0.15%) ⬆️
Linux_2 55.89% <ø> (+0.02%) ⬆️
Linux_3 40.69% <58.97%> (+0.30%) ⬆️
Linux_4 31.46% <ø> (+0.12%) ⬆️
Windows_1 30.32% <ø> (+0.15%) ⬆️
Windows_2 55.85% <ø> (+0.02%) ⬆️
Windows_3 40.69% <58.97%> (+0.30%) ⬆️
Windows_4 31.46% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kamingleung
Copy link

@weiwang118 Thank you for your updates, a few follow-up items:

  1. For the connection type tabs, can we use the compressed button groups like in the mockups?
image
  1. The top padding on the container should be the same length as the left, right padding.
    image

  2. For the Connect OpenSearch Cluster page, should we rename the action button to "Connect to OpenSearch cluster"? This will make it consistent with other create pages.
    image

cc: @kgcreative @virajsanghvi

@weiwang118
Copy link
Contributor Author

Already updated the pr to address your comments. Thanks!!! @kamingleung
Screenshot 2024-08-26 at 20 19 04
Screenshot 2024-08-26 at 20 19 14
Screenshot 2024-08-26 at 20 19 24

Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left 1 comment. Could you also check the failed CIs?

<EuiText grow={false}>
<h4>
<EuiText grow={false} size="s">
<h3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be h2?
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, we intentionally use h3 to better align with the other datasources pages. And also we don't want it too big since it's just a section title. For the failed test, it's a flaky test that doesn't relate to my code change.

Summary of all failing tests
 FAIL  src/plugins/console/public/application/components/import_flyout.test.tsx
  ● ImportFlyout Component › should handle import process with default import mode

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is by requirements of fit and finish. It applies to all plugins. If you think there are other pages that violates this, let's fix those too. I'll share with you the fit and finish guidance offline

Copy link
Contributor Author

@weiwang118 weiwang118 Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change section title to h2 in new commit. kindly request approval. Thanks!!!
Screenshot 2024-08-27 at 14 01 37
Screenshot 2024-08-27 at 14 01 02
Screenshot 2024-08-27 at 14 01 15
Screenshot 2024-08-27 at 14 01 23

Signed-off-by: Wei Wang <weiwangv@amazon.com>
Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, assuming the CI can pass, be sure to also check the codecov CI to make sure we don't decrease the code coverage.

@BionIT
Copy link
Collaborator

BionIT commented Aug 28, 2024

Looks like failed coverage check

@BionIT BionIT merged commit cb273fc into opensearch-project:main Aug 28, 2024
65 of 67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 30, 2024
…7833)

* Implement new page header for admin data sources page

Signed-off-by: Wei Wang <weiwangv@amazon.com>

* update unit tests for page header change

Signed-off-by: Wei Wang <weiwangv@amazon.com>

* make button group smaller and change section title to h2

Signed-off-by: Wei Wang <weiwangv@amazon.com>

---------

Signed-off-by: Wei Wang <weiwangv@amazon.com>
Co-authored-by: Wei Wang <weiwangv@amazon.com>
(cherry picked from commit cb273fc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ZilongX pushed a commit that referenced this pull request Aug 30, 2024
…7833) (#7945)

* Implement new page header for admin data sources page



* update unit tests for page header change



* make button group smaller and change section title to h2



---------



(cherry picked from commit cb273fc)

Signed-off-by: Wei Wang <weiwangv@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Wei Wang <weiwangv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x first-time-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants