-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Page Header]Implement new page header for admin data sources page #7833
Conversation
Signed-off-by: Wei Wang <weiwangv@amazon.com>
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
❌ Changelog Entry Missing HyphenChangelog entries must begin with a hyphen (-). |
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "refactor". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7833 +/- ##
==========================================
+ Coverage 63.83% 64.17% +0.34%
==========================================
Files 3661 3659 -2
Lines 81347 80811 -536
Branches 12978 12879 -99
==========================================
- Hits 51926 51862 -64
+ Misses 26235 25763 -472
Partials 3186 3186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Wei Wang <weiwangv@amazon.com>
@weiwang118 Thank you for your updates, a few follow-up items:
|
Already updated the pr to address your comments. Thanks!!! @kamingleung |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left 1 comment. Could you also check the failed CIs?
<EuiText grow={false}> | ||
<h4> | ||
<EuiText grow={false} size="s"> | ||
<h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, we intentionally use h3 to better align with the other datasources pages. And also we don't want it too big since it's just a section title. For the failed test, it's a flaky test that doesn't relate to my code change.
Summary of all failing tests
FAIL src/plugins/console/public/application/components/import_flyout.test.tsx
● ImportFlyout Component › should handle import process with default import mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is by requirements of fit and finish. It applies to all plugins. If you think there are other pages that violates this, let's fix those too. I'll share with you the fit and finish guidance offline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Wei Wang <weiwangv@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve, assuming the CI can pass, be sure to also check the codecov CI to make sure we don't decrease the code coverage.
Looks like failed coverage check |
…7833) * Implement new page header for admin data sources page Signed-off-by: Wei Wang <weiwangv@amazon.com> * update unit tests for page header change Signed-off-by: Wei Wang <weiwangv@amazon.com> * make button group smaller and change section title to h2 Signed-off-by: Wei Wang <weiwangv@amazon.com> --------- Signed-off-by: Wei Wang <weiwangv@amazon.com> Co-authored-by: Wei Wang <weiwangv@amazon.com> (cherry picked from commit cb273fc) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…7833) (#7945) * Implement new page header for admin data sources page * update unit tests for page header change * make button group smaller and change section title to h2 --------- (cherry picked from commit cb273fc) Signed-off-by: Wei Wang <weiwangv@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Wei Wang <weiwangv@amazon.com>
Description
Implement new page header and Look&Feel UI changes for Admin->Data Sources page.
Issues Resolved
Screenshot
New Page
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration