Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]feat: align essentials use case id #7873

Conversation

SuZhou-Joe
Copy link
Member

@SuZhou-Joe SuZhou-Joe commented Aug 28, 2024

Description

This PR is to make the id of the essentials user case semantically aligned with the name of the use case to reduce confusion.

Issues Resolved

Screenshot

Testing the changes

Changelog

  • feat: align essentials use case id

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@SuZhou-Joe SuZhou-Joe force-pushed the feature/align-id-on-essentials-use-case branch from d087a98 to 9f9e5e2 Compare August 28, 2024 00:27
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: why this file gets changed?

Copy link
Member Author

@SuZhou-Joe SuZhou-Joe Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone forgot to update the file in 1.3.19 release I guess.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.21%. Comparing base (8a96664) to head (9f9e5e2).
Report is 393 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7873   +/-   ##
=======================================
  Coverage   64.21%   64.21%           
=======================================
  Files        3670     3670           
  Lines       81090    81091    +1     
  Branches    12906    12906           
=======================================
+ Hits        52073    52076    +3     
+ Misses      25825    25824    -1     
+ Partials     3192     3191    -1     
Flag Coverage Δ
Linux_1 30.20% <100.00%> (+<0.01%) ⬆️
Linux_2 56.05% <100.00%> (ø)
Linux_3 40.57% <100.00%> (+<0.01%) ⬆️
Linux_4 31.33% <100.00%> (ø)
Windows_1 30.22% <100.00%> (+<0.01%) ⬆️
Windows_2 56.00% <100.00%> (ø)
Windows_3 40.57% <100.00%> (+<0.01%) ⬆️
Windows_4 31.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe changed the title feat: align essentials use case id [Workspace]feat: align essentials use case id Aug 28, 2024
@SuZhou-Joe SuZhou-Joe merged commit 4b17e01 into opensearch-project:main Aug 29, 2024
70 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7873-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 4b17e015d7659d12b2bcd83ed952a527c6dd536a
# Push it to GitHub
git push --set-upstream origin backport/backport-7873-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7873-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 29, 2024
* feat: align essentials use case id

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* Changeset file for PR #7873 created/updated

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 4b17e01)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Aug 29, 2024
* feat: align essentials use case id



* Changeset file for PR #7873 created/updated

---------



(cherry picked from commit 4b17e01)

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants