Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Refactor get start card at new home page #7920

Merged

Conversation

yubonluo
Copy link
Contributor

Description

Refactor get start card at new home page according the latest ui design.

The card icon will been update as the followed commit.

Issues Resolved

Screenshot

2024-08-29.23.15.27.mp4

Testing the changes

Changelog

  • refactor: [Workspace] Refactor get start card at new home page

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: yubonluo <yubonluo@amazon.com>
opensearch-changeset-bot bot and others added 3 commits August 29, 2024 15:18
Signed-off-by: yubonluo <yubonluo@amazon.com>
…OpenSearch-Dashboards into 2.17/refactor-get-started-card
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.33%. Comparing base (76de9a3) to head (2f9179d).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...nents/home_get_start_card/setup_get_start_card.tsx 81.81% 3 Missing and 1 partial ⚠️
...blic/components/card_container/card_embeddable.tsx 0.00% 0 Missing and 1 partial ⚠️
...nt_management/public/components/section_render.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7920      +/-   ##
==========================================
- Coverage   64.33%   64.33%   -0.01%     
==========================================
  Files        3677     3678       +1     
  Lines       81206    81202       -4     
  Branches    12946    12943       -3     
==========================================
- Hits        52243    52238       -5     
  Misses      25750    25750              
- Partials     3213     3214       +1     
Flag Coverage Δ
Linux_1 30.74% <86.95%> (-0.01%) ⬇️
Linux_2 56.19% <ø> (ø)
Linux_3 40.60% <0.00%> (-0.01%) ⬇️
Linux_4 31.40% <0.00%> (+<0.01%) ⬆️
Windows_1 30.76% <86.95%> (-0.01%) ⬇️
Windows_2 56.14% <ø> (ø)
Windows_3 40.61% <0.00%> (-0.01%) ⬇️
Windows_4 31.40% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruanyl
ruanyl previously approved these changes Aug 30, 2024
Copy link
Member

@ruanyl ruanyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments

Signed-off-by: yubonluo <yubonluo@amazon.com>
@SuZhou-Joe SuZhou-Joe merged commit d13007a into opensearch-project:main Sep 3, 2024
73 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 3, 2024
* refactor started card

Signed-off-by: yubonluo <yubonluo@amazon.com>

* refactor new home page get start card

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #7920 created/updated

* revert code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* optimize the code

Signed-off-by: yubonluo <yubonluo@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit d13007a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Sep 3, 2024
* refactor started card



* refactor new home page get start card



* Changeset file for PR #7920 created/updated

* revert code



* optimize the code



---------



(cherry picked from commit d13007a)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants