Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.17] Add query result and time to the query editor footer #8004

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 7e8612f from #7951.

* add query result to the footer

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix unit test

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* conditional language

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* native language still use toast

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* refactor to not use two states

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* address comments

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit 7e8612f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 11.76471% with 30 lines in your changes missing coverage. Please review.

Project coverage is 60.52%. Comparing base (880634f) to head (8b476b5).
Report is 3 commits behind head on 2.17.

Files with missing lines Patch % Lines
...query_string/language_service/lib/query_result.tsx 0.00% 10 Missing ⚠️
...ic/application/view_components/utils/use_search.ts 0.00% 9 Missing ⚠️
...lic/application/view_components/canvas/top_nav.tsx 0.00% 6 Missing ⚠️
src/plugins/query_enhancements/common/utils.ts 0.00% 3 Missing ⚠️
...ublic/application/view_components/canvas/index.tsx 0.00% 1 Missing ⚠️
...ector/common/adapters/request/request_responder.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             2.17    #8004      +/-   ##
==========================================
- Coverage   61.13%   60.52%   -0.62%     
==========================================
  Files        3686     3723      +37     
  Lines       87137    88090     +953     
  Branches    13382    13608     +226     
==========================================
+ Hits        53274    53316      +42     
- Misses      30633    31544     +911     
  Partials     3230     3230              
Flag Coverage Δ
Linux_1 28.22% <0.00%> (-0.59%) ⬇️
Linux_2 56.36% <ø> (ø)
Linux_4 29.66% <16.66%> (-0.01%) ⬇️
Windows_1 28.23% <0.00%> (-0.59%) ⬇️
Windows_2 56.31% <ø> (ø)
Windows_3 37.41% <3.57%> (-0.58%) ⬇️
Windows_4 29.66% <16.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abbyhu2000 abbyhu2000 added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Sep 4, 2024
@kavilla kavilla merged commit dce573e into 2.17 Sep 5, 2024
66 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports discover for discover reinvent distinguished-contributor failed changeset Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants