Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Discover Embeddable not showing _source when all other column are removed #8167

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Fix Discover Embeddable not showing _source when all other column are removed #8167

merged 2 commits into from
Sep 12, 2024

Conversation

LDrago27
Copy link
Collaborator

@LDrago27 LDrago27 commented Sep 12, 2024 •
edited
Loading

Description

Fix Discover Embeddable not showing _source when all other column are removed.

Issues Resolved

Screenshot

Issue Before the fix

BeforeFix.mp4

After Fix

After.Fix.mp4

Testing the changes

  • Navigate to Dashboards page
  • Add a discover Save Search which contains multiple columns
  • Remove all the columns
  • Check if _source column is displayed

Changelog

  • fix: Discover Embeddable not showing _source when all other column are removed

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@LDrago27
Fix Discover Embeddable not showing _source when all other columns ar…
bcba38b 
…e removed

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
@LDrago27 LDrago27 added the discover for discover reinvent label Sep 12, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.89%. Comparing base (7aecd73) to head (25e365c).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8167      +/-   ##
==========================================
+ Coverage   63.84%   63.89%   +0.05%     
==========================================
  Files        3738     3739       +1     
  Lines       88723    88762      +39     
  Branches    13803    13814      +11     
==========================================
+ Hits        56646    56718      +72     
+ Misses      31480    31446      -34     
- Partials      597      598       +1
Flag Coverage Δ
Linux_1 29.96% <ø> (+<0.01%) ⬆️
Linux_2 58.79% <ø> (ø)
Linux_3 40.25% <ø> (+<0.01%) ⬆️
Linux_4 31.36% <ø> (+0.15%) ⬆️
Windows_1 29.97% <ø> (+<0.01%) ⬆️
Windows_2 58.74% <ø> (ø)
Windows_3 40.25% <ø> (+<0.01%) ⬆️
Windows_4 31.36% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abbyhu2000 abbyhu2000 merged commit 9ab4377 into opensearch-project:main Sep 12, 2024
73 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 12, 2024
@github-actions @opensearch-changeset-bot
Fix Discover Embeddable not showing _source when all other column are…
2071cfd 
… removed (#8167)

* Fix Discover Embeddable not showing _source when all other columns are removed

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

* Changeset file for PR #8167 created/updated

---------

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 9ab4377)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 12, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 12, 2024
@github-actions @opensearch-changeset-bot
Fix Discover Embeddable not showing _source when all other column are…
309e643 
… removed (#8167)

* Fix Discover Embeddable not showing _source when all other columns are removed

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>

* Changeset file for PR #8167 created/updated

---------

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 9ab4377)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 12, 2024
Merged
LDrago27 pushed a commit that referenced this pull request Sep 12, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
Fix Discover Embeddable not showing _source when all other column are…
f09fb87 
… removed (#8167) (#8170)

* Fix Discover Embeddable not showing _source when all other columns are removed
* Changeset file for PR #8167 created/updated

---------
(cherry picked from commit 9ab4377)

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
LDrago27 pushed a commit that referenced this pull request Sep 12, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
Fix Discover Embeddable not showing _source when all other column are…
8386b12 
… removed (#8167) (#8169)

* Fix Discover Embeddable not showing _source when all other columns are removed
* Changeset file for PR #8167 created/updated

---------
(cherry picked from commit 9ab4377)

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbyhu2000 abbyhu2000 abbyhu2000 approved these changes

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.17 discover for discover reinvent seasoned-contributor v2.17.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LDrago27 @ashwin-pc @abbyhu2000