-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace]Fix workspace detail UI bugs #8188
[Workspace]Fix workspace detail UI bugs #8188
Conversation
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
ebc9d8b
to
2e38a09
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8188 +/- ##
==========================================
- Coverage 64.04% 64.03% -0.02%
==========================================
Files 3740 3740
Lines 88582 88588 +6
Branches 13791 13794 +3
==========================================
- Hits 56731 56724 -7
- Misses 31253 31266 +13
Partials 598 598
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fixes and refactor!
* Render — when description is empty Signed-off-by: Lin Wang <wonglam@amazon.com> * Type workspace name in workspace delete workspace modal Signed-off-by: Lin Wang <wonglam@amazon.com> * Update use case icon in workspace detail page Signed-off-by: Lin Wang <wonglam@amazon.com> * Update Owner to Owners Signed-off-by: Lin Wang <wonglam@amazon.com> * Add copy tooltip for copy workspace id Signed-off-by: Lin Wang <wonglam@amazon.com> * Update gap between tab header and content Signed-off-by: Lin Wang <wonglam@amazon.com> * Update hr margin in tab content Signed-off-by: Lin Wang <wonglam@amazon.com> * Move form error banner inside tab content Signed-off-by: Lin Wang <wonglam@amazon.com> * Reduce the gap between associate button Signed-off-by: Lin Wang <wonglam@amazon.com> * Make input readOnly instead of disabled Signed-off-by: Lin Wang <wonglam@amazon.com> * Update collaborator form group title and description Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR #8188 created/updated * Reduce delete button size avoid line-height update Signed-off-by: Lin Wang <wonglam@amazon.com> * Update "Remove data source(s)" to "Remove data association(s)" Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix data source connection selected items not clear after canceled Signed-off-by: Lin Wang <wonglam@amazon.com> * Update toast message on remove association flow Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 096b568) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Render — when description is empty * Type workspace name in workspace delete workspace modal * Update use case icon in workspace detail page * Update Owner to Owners * Add copy tooltip for copy workspace id * Update gap between tab header and content * Update hr margin in tab content * Move form error banner inside tab content * Reduce the gap between associate button * Make input readOnly instead of disabled * Update collaborator form group title and description * Changeset file for PR #8188 created/updated * Reduce delete button size avoid line-height update * Update "Remove data source(s)" to "Remove data association(s)" * Fix data source connection selected items not clear after canceled * Update toast message on remove association flow --------- (cherry picked from commit 096b568) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…ensearch-project#8220) * Render — when description is empty * Type workspace name in workspace delete workspace modal * Update use case icon in workspace detail page * Update Owner to Owners * Add copy tooltip for copy workspace id * Update gap between tab header and content * Update hr margin in tab content * Move form error banner inside tab content * Reduce the gap between associate button * Make input readOnly instead of disabled * Update collaborator form group title and description * Changeset file for PR opensearch-project#8188 created/updated * Reduce delete button size avoid line-height update * Update "Remove data source(s)" to "Remove data association(s)" * Fix data source connection selected items not clear after canceled * Update toast message on remove association flow --------- (cherry picked from commit 096b568) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
This PR fix a bunch of UI bugs in workspace detail page, here are the list of changes:
—
when description is emptyIssues Resolved
Screenshot
Testing the changes
yarn osd bootstrap --single-version ignore
config/opensearch_dashboards.yml
yarn start --no-base-path
Changelog
Check List
yarn test:jest
yarn test:jest_integration