[navigation]fix: optimize the logic to detect current nav group #8189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8189 +/- ##
=======================================
Coverage 64.03% 64.03%
=======================================
Files 3740 3740
Lines 88580 88589 +9
Branches 13790 13794 +4
=======================================
+ Hits 56720 56726 +6
- Misses 31262 31265 +3
Partials 598 598
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn and
ruanyl
as code owners
SuZhou-Joe
requested review from
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
|
@SuZhou-Joe should this be tagged with 2.17.1 now? |
Yes, updated. |
ruanyl
approved these changes
Sep 24, 2024
ZilongX
approved these changes
Sep 24, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 24, 2024
* fix: optimize the logic to detect current nav group Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #8189 created/updated --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 9a88bf5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 25, 2024
… (#8321) * fix: optimize the logic to detect current nav group * feat: optimize code * Changeset file for PR #8189 created/updated --------- (cherry picked from commit 9a88bf5) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
yubonluo
pushed a commit
to yubonluo/OpenSearch-Dashboards
that referenced
this pull request
Sep 25, 2024
…search-project#8189) (opensearch-project#8321) * fix: optimize the logic to detect current nav group * feat: optimize code * Changeset file for PR opensearch-project#8189 created/updated --------- (cherry picked from commit 9a88bf5) Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to fix the bug that:
left+nav.mov
Issues Resolved
Screenshot
1. current nav group will be mapped to global system nav group even if user is in a workspace.
20240913162710198.mp4
2. current nav group will be mapped to a nav group even when user is out of a workspace.
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration