-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace]Add tooltip in workspace settings top delete button #8213
Merged
SuZhou-Joe
merged 2 commits into
opensearch-project:main
from
wanglam:feat-add-tooltip-in-workspace-settings-delete-button
Sep 18, 2024
Merged
[Workspace]Add tooltip in workspace settings top delete button #8213
SuZhou-Joe
merged 2 commits into
opensearch-project:main
from
wanglam:feat-add-tooltip-in-workspace-settings-delete-button
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <wonglam@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8213 +/- ##
==========================================
- Coverage 64.05% 64.05% -0.01%
==========================================
Files 3741 3741
Lines 88629 88629
Branches 13801 13801
==========================================
- Hits 56771 56770 -1
- Misses 31260 31261 +1
Partials 598 598
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wanglam
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
September 18, 2024 03:33
ruanyl
approved these changes
Sep 18, 2024
SuZhou-Joe
approved these changes
Sep 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 18, 2024
* Add tooltip in workspace detail top delete button Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR #8213 created/updated --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit cea39b8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Sep 20, 2024
#8221) * Add tooltip in workspace detail top delete button * Changeset file for PR #8213 created/updated --------- (cherry picked from commit cea39b8) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
yubonluo
pushed a commit
to yubonluo/OpenSearch-Dashboards
that referenced
this pull request
Sep 25, 2024
…earch-project#8213) (opensearch-project#8221) * Add tooltip in workspace detail top delete button * Changeset file for PR opensearch-project#8213 created/updated --------- (cherry picked from commit cea39b8) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for adding "Delete workspace" tooltip for workspace settings top right delete button.
Issues Resolved
Screenshot
Screen.Recording.2024-09-18.at.11.48.31.mov
Testing the changes
yarn osd bootstrap --single-version ignore
config/opensearch_dashboards.yml
yarn start --no-base-path
Changelog
Check List
yarn test:jest
yarn test:jest_integration