Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix initial page UI issues #8217

Merged
merged 4 commits into from
Sep 20, 2024
Merged

[Bug] Fix initial page UI issues #8217

merged 4 commits into from
Sep 20, 2024

Conversation

yubonluo
Copy link
Contributor

Description

  • Remove the vertical centering. Add extra large padding to the top of the page.
  • Update the content to match figma (h1 and the paragraph)
  • Make the space between the label and the popout icon smaller for the "Learn more from documentation"
  • Add "External link" icon to the playgound link
  • The spacing between the panel and the "Settings and setup" link should be 16px - medium

Issues Resolved

Screenshot

image

Testing the changes

Changelog

  • fix: Fix initial page UI issues

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yubonluo
fix initial page ui issue
41494b7 
Signed-off-by: yubonluo <yubonluo@amazon.com>
ruanyl
ruanyl previously approved these changes Sep 18, 2024
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.09%. Comparing base (cea39b8) to head (dc2eb6c).
Report is 36 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8217      +/-   ##
==========================================
+ Coverage   64.05%   64.09%   +0.03%     
==========================================
  Files        3741     3744       +3     
  Lines       88635    88821     +186     
  Branches    13804    13840      +36     
==========================================
+ Hits        56775    56929     +154     
- Misses      31262    31278      +16     
- Partials      598      614      +16
Flag Coverage Δ
Linux_1 30.04% <ø> (-0.03%) ⬇️
Linux_2 58.85% <ø> (+0.02%) ⬆️
Linux_3 40.33% <ø> (-0.05%) ⬇️
Linux_4 31.57% <ø> (+0.11%) ⬆️
Windows_1 30.06% <ø> (-0.03%) ⬇️
Windows_2 58.80% <ø> (+0.02%) ⬆️
Windows_3 40.33% <ø> (-0.05%) ⬇️
Windows_4 31.57% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanyl ruanyl added the 2.17.1 label Sep 19, 2024
SuZhou-Joe
SuZhou-Joe previously approved these changes Sep 20, 2024
View reviewed changes
@yubonluo
fix test error
dc2eb6c 
Signed-off-by: yubonluo <yubonluo@amazon.com>
@yubonluo yubonluo dismissed stale reviews from SuZhou-Joe and ruanyl via dc2eb6c September 20, 2024 07:54
@SuZhou-Joe SuZhou-Joe merged commit ea8d5c4 into opensearch-project:main Sep 20, 2024
67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 20, 2024
@github-actions @opensearch-changeset-bot
[Bug] Fix initial page UI issues (#8217)
ab332bc 
* fix initial page ui issue

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR #8217 created/updated

* fix test error

Signed-off-by: yubonluo <yubonluo@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit ea8d5c4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 20, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Sep 20, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[Bug] Fix initial page UI issues (#8217) (#8270)
5ce2451 
* fix initial page ui issue



* Changeset file for PR #8217 created/updated

* fix test error



---------



(cherry picked from commit ea8d5c4)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
virajsanghvi pushed a commit to virajsanghvi/OpenSearch-Dashboards that referenced this pull request Sep 24, 2024
@yubonluo @opensearch-changeset-bot @virajsanghvi
[Bug] Fix initial page UI issues (opensearch-project#8217)
0e9354d 
* fix initial page ui issue

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Changeset file for PR opensearch-project#8217 created/updated

* fix test error

Signed-off-by: yubonluo <yubonluo@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
yubonluo pushed a commit to yubonluo/OpenSearch-Dashboards that referenced this pull request Sep 25, 2024
@opensearch-trigger-bot @github-actions
@opensearch-changeset-bot @yubonluo
[Bug] Fix initial page UI issues (opensearch-project#8217) (opensearc…
e5ea4ce 
…h-project#8270)

* fix initial page ui issue



* Changeset file for PR opensearch-project#8217 created/updated

* fix test error



---------



(cherry picked from commit ea8d5c4)

Signed-off-by: yubonluo <yubonluo@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
2.17.1 all-star-contributor backport 2.x in-next workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yubonluo @ruanyl @SuZhou-Joe @AMoo-Miki