Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @osd/std to prettify objects for display #8232

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Use @osd/std to prettify objects for display #8232

merged 2 commits into from
Sep 19, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

Description

Use @osd/std to prettify objects for display

Issues Resolved

Fixes #8211

Testing the changes

Follow steps in #8211

Changelog

  • fix: Use @osd/std to prettify objects for display

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.05%. Comparing base (cc5531b) to head (0b173be).
Report is 35 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8232   +/-   ##
=======================================
  Coverage   64.05%   64.05%           
=======================================
  Files        3741     3741           
  Lines       88635    88683   +48     
  Branches    13804    13817   +13     
=======================================
+ Hits        56776    56810   +34     
  Misses      31261    31261           
- Partials      598      612   +14
Flag Coverage Δ
Linux_1 30.05% <0.00%> (-0.03%) ⬇️
Linux_2 58.85% <0.00%> (+0.02%) ⬆️
Linux_3 40.34% <100.00%> (-0.04%) ⬇️
Linux_4 31.43% <0.00%> (-0.03%) ⬇️
Windows_1 30.06% <0.00%> (-0.03%) ⬇️
Windows_2 58.80% <0.00%> (+0.02%) ⬆️
Windows_3 40.34% <100.00%> (-0.04%) ⬇️
Windows_4 31.43% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMoo-Miki AMoo-Miki merged commit 6e3351c into opensearch-project:main Sep 19, 2024
67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 19, 2024
@github-actions @opensearch-changeset-bot
Use @osd/std to prettify objects for display (#8232)
512963e 
* Use @osd/std to stringify JSON when formatting objects for display

Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR #8232 created/updated

---------

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 6e3351c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 19, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 19, 2024
@github-actions @opensearch-changeset-bot
Use @osd/std to prettify objects for display (#8232)
1fdb564 
* Use @osd/std to stringify JSON when formatting objects for display

Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR #8232 created/updated

---------

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 6e3351c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 19, 2024
Merged
abbyhu2000 pushed a commit that referenced this pull request Sep 21, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
Use @osd/std to prettify objects for display (#8232) (#8254)
c0fc91e 
* Use @osd/std to stringify JSON when formatting objects for display



* Changeset file for PR #8232 created/updated

---------



(cherry picked from commit 6e3351c)

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
abbyhu2000 pushed a commit that referenced this pull request Sep 21, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
Use @osd/std to prettify objects for display (#8232) (#8253)
91e4fe5 
* Use @osd/std to stringify JSON when formatting objects for display



* Changeset file for PR #8232 created/updated

---------



(cherry picked from commit 6e3351c)

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
virajsanghvi pushed a commit to virajsanghvi/OpenSearch-Dashboards that referenced this pull request Sep 24, 2024
@AMoo-Miki @opensearch-changeset-bot @virajsanghvi
Use @osd/std to prettify objects for display (opensearch-project#8232)
cff56e1 
* Use @osd/std to stringify JSON when formatting objects for display

Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR opensearch-project#8232 created/updated

---------

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
abbyhu2000 added a commit to abbyhu2000/OpenSearch-Dashboards that referenced this pull request Sep 24, 2024
@abbyhu2000
Revert "Use @osd/std to prettify objects for display (opensearch-proj…
7919621 
…ect#8232) (opensearch-project#8254)"

This reverts commit c0fc91e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sejli sejli sejli approved these changes

@LDrago27 LDrago27 LDrago27 approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
2.17.1 backport 2.x backport 2.17 distinguished-contributor in-next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] JSON.stringify() doesn't know how to serialize a BigInt in Discover
3 participants
@AMoo-Miki @LDrago27 @sejli