-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sample data page UI when useUpdatedUX enabled #8291
Update sample data page UI when useUpdatedUX enabled #8291
Conversation
Signed-off-by: Lin Wang <wonglam@amazon.com>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8291 +/- ##
==========================================
- Coverage 60.92% 60.90% -0.03%
==========================================
Files 3749 3749
Lines 89021 89034 +13
Branches 13899 13899
==========================================
- Hits 54236 54222 -14
- Misses 31423 31494 +71
+ Partials 3362 3318 -44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lin Wang <wonglam@amazon.com>
return await renderApp( | ||
params.element, | ||
{ | ||
...coreStart, | ||
navigation, | ||
setHeaderActionMenu: params.setHeaderActionMenu, | ||
}, | ||
params.history | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this change for home page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The page will be broken if we visit /app/home#/tutorial_directory
directly. To align with the latest design, I think we should render the same UI for this entry.
Signed-off-by: Lin Wang <wonglam@amazon.com>
* Update sample data page with latest UI when useUpdatedUX enabled Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix crashed in home page Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR #8291 created/updated * Reduce spacing between sample data cards Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit c1a349a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Update sample data page with latest UI when useUpdatedUX enabled * Fix crashed in home page * Changeset file for PR #8291 created/updated * Reduce spacing between sample data cards --------- (cherry picked from commit c1a349a) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…ect#8291) (opensearch-project#8377) * Update sample data page with latest UI when useUpdatedUX enabled * Fix crashed in home page * Changeset file for PR opensearch-project#8291 created/updated * Reduce spacing between sample data cards --------- (cherry picked from commit c1a349a) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
This PR is for updating the sample data page UI when useUpdatedUX enabled. It mainly includes below changes:
Issues Resolved
#8312
Screenshot
Testing the changes
yarn osd bootstrap --single-version ignore
config/opensearch_dashboards.yml
yarn start --no-base-path
Changelog
Check List
yarn test:jest
yarn test:jest_integration