Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update oui to 1.14 #8372

Merged

Conversation

virajsanghvi
Copy link
Collaborator

Description

Update oui to 1.14 - includes removal of Fira Code which was removed in favor of Source Code Pro for v9 theme

Issues Resolved

N/A

Screenshot

N/A

Testing the changes

Checked changes locally

Changelog

  • chore: Update oui to 1.14

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.92%. Comparing base (6fd284f) to head (f0441ad).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8372      +/-   ##
==========================================
- Coverage   64.14%   60.92%   -3.22%     
==========================================
  Files        3743     3749       +6     
  Lines       88836    89020     +184     
  Branches    13852    13899      +47     
==========================================
- Hits        56981    54235    -2746     
- Misses      31240    31423     +183     
- Partials      615     3362    +2747     
Flag Coverage Δ
Linux_1 28.85% <0.00%> (-1.22%) ⬇️
Linux_2 56.35% <100.00%> (-2.52%) ⬇️
Linux_3 37.76% <0.00%> (-2.61%) ⬇️
Linux_4 29.94% <0.00%> (-1.65%) ⬇️
Windows_1 28.87% <0.00%> (-1.22%) ⬇️
Windows_2 56.30% <100.00%> (-2.51%) ⬇️
Windows_3 37.76% <0.00%> (-2.61%) ⬇️
Windows_4 29.94% <0.00%> (-1.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@virajsanghvi virajsanghvi added backport 2.x look & feel Look and Feel Improvements v2.18.0 labels Sep 30, 2024
@virajsanghvi virajsanghvi merged commit b8b563d into opensearch-project:main Sep 30, 2024
71 of 73 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8372-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b8b563d0460401168f990c2ca5f11ab0e1215c2d
# Push it to GitHub
git push --set-upstream origin backport/backport-8372-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8372-to-2.x.

virajsanghvi added a commit to virajsanghvi/OpenSearch-Dashboards that referenced this pull request Sep 30, 2024
* chore: Update oui to 1.14

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>

* Changeset file for PR opensearch-project#8372 created/updated

---------

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit b8b563d)
virajsanghvi added a commit that referenced this pull request Sep 30, 2024
* chore: Update oui to 1.14

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>

* Changeset file for PR #8372 created/updated

---------

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit b8b563d)
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 3, 2024
…ct#8390)

* chore: Update oui to 1.14

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>

* Changeset file for PR opensearch-project#8372 created/updated

---------

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit b8b563d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants