[Workspace] Refactor summary panel in workspace create page #8381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <yubonluo@amazon.com>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
ruanyl
previously approved these changes
Sep 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8381 +/- ##
=======================================
Coverage 60.92% 60.92%
=======================================
Files 3750 3749 -1
Lines 89054 89055 +1
Branches 13910 13911 +1
=======================================
+ Hits 54257 54260 +3
+ Misses 31433 31432 -1
+ Partials 3364 3363 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
previously approved these changes
Sep 30, 2024
wanglam
reviewed
Sep 30, 2024
| )} | ||
| </FieldSummaryItem> | ||
| <FieldSummaryItem field={RightSidebarScrollField.Name}>{formData.name}</FieldSummaryItem> | ||
| <FieldSummaryItem field={RightSidebarScrollField.Description}> |
There was a problem hiding this comment.
Seems this description summary has been removed, can we added it back?
wanglam
reviewed
Sep 30, 2024
| @@ -122,3 +122,33 @@ export const DetailTabTitles: { [key in DetailTab]: string } = { | |||
| export const PERMISSION_TYPE_LABEL_ID = 'workspace-form-permission-type-label'; | |||
| export const PERMISSION_COLLABORATOR_LABEL_ID = 'workspace-form-permission-collaborator-label'; | |||
| export const PERMISSION_ACCESS_LEVEL_LABEL_ID = 'workspace-form-permission-access-level-label'; | |||
|
|
|||
| export const permissionModeOptions = [ | |||
There was a problem hiding this comment.
Nice refactor for reusing the permissionModeOptions.
Signed-off-by: yubonluo <yubonluo@amazon.com>
SuZhou-Joe
approved these changes
Sep 30, 2024
ruanyl
approved these changes
Sep 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
* Refactor summary panel in workspace create page Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #8381 created/updated * add description Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit f9b8c8a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 30, 2024
…8388) * Refactor summary panel in workspace create page * Changeset file for PR #8381 created/updated * add description --------- (cherry picked from commit f9b8c8a) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 3, 2024
…ch-project#8381) (opensearch-project#8388) * Refactor summary panel in workspace create page * Changeset file for PR opensearch-project#8381 created/updated * add description --------- (cherry picked from commit f9b8c8a) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor summary panel in workspace create page
Issues Resolved
Screenshot
2024-09-29.18.23.49.mp4
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration