[Workspace] Refactor data source association panel #8383

Kapian1234 · 2024-09-30T05:28:29Z

Description

Refactor data source association panel

Issues Resolved

Screenshot

before

after

Testing the changes

Changelog

feat: Refactor data source association panel

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

wanglam · 2024-09-30T05:33:24Z

src/plugins/workspace/public/components/workspace_creator/workspace_creator_form.tsx

@@ -109,7 +117,7 @@ export const WorkspaceCreatorForm = (props: WorkspaceCreatorFormProps) => {
          <EuiSpacer size="m" />
          {/* SelectDataSourcePanel is only visible for dashboard admin and when data source is enabled*/}
          {isDashboardAdmin && isDataSourceEnabled && (
-            <>


Can we keep this fragment?

wanglam · 2024-09-30T05:34:09Z

src/plugins/workspace/public/components/workspace_creator/workspace_creator_form.tsx

          )}
+          <EuiSpacer size="s" />


I think these spacer should be inside fragment, then it won't take extra spaces when data source not enabled.

Maybe these spacer could be deleted since we have padding in the panel now

These spacing is between panel and panel right? This spacing should follow data source panel. It should be hidden if data source panel not displayed.

oh, I get it. thank you

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

wanglam · 2024-09-30T06:01:23Z

src/plugins/workspace/public/components/workspace_creator/workspace_creator_form.tsx

-                  {i18n.translate('workspace.creator.form.associateDataSourceTitle', {
-                    defaultMessage: 'Associate data sources',
+              <EuiPanel>
+                <EuiTitle


Can we use EuiText + h2 as panel title like this to align with the guidance.

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

wanglam · 2024-09-30T07:02:57Z

src/plugins/workspace/public/components/workspace_creator/workspace_creator_form.tsx

-                showDataSourceManagement={true}
-              />
+                </EuiText>
+                <SelectDataSourcePanel


Do we need more spacing between description and SelectDataSourcePanel?

In SelectDataSourcePanel, there's already a <EuiSpacer size="m" />, and it would display only when the table exists

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

src/plugins/workspace/public/components/workspace_form/workspace_permission_setting_input.tsx

wanglam · 2024-09-30T09:28:56Z

src/plugins/workspace/public/components/workspace_form/workspace_permission_setting_input.tsx

@Kapian1234 I think this file should not be included in this PR. Can we remove it?

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

* refactor association panel Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Changeset file for PR #8383 created/updated * resolve some issues Signed-off-by: Kapian1234 <wanjinch@amazon.com> * update title style Signed-off-by: Kapian1234 <wanjinch@amazon.com> * update title style Signed-off-by: Kapian1234 <wanjinch@amazon.com> * update placeholder Signed-off-by: Kapian1234 <wanjinch@amazon.com> * update placeholder Signed-off-by: Kapian1234 <wanjinch@amazon.com> * / Signed-off-by: Kapian1234 <wanjinch@amazon.com> --------- Signed-off-by: Kapian1234 <wanjinch@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 83d5fba) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* refactor association panel * Changeset file for PR #8383 created/updated * resolve some issues * update title style * update title style * update placeholder * update placeholder * / --------- (cherry picked from commit 83d5fba) Signed-off-by: Kapian1234 <wanjinch@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…t#8383) (opensearch-project#8419) * refactor association panel * Changeset file for PR opensearch-project#8383 created/updated * resolve some issues * update title style * update title style * update placeholder * update placeholder * / --------- (cherry picked from commit 83d5fba) Signed-off-by: Kapian1234 <wanjinch@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

refactor association panel

0b2bb1b

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

github-actions bot added the valued-contributor label Sep 30, 2024

Kapian1234 marked this pull request as ready for review September 30, 2024 05:28

Changeset file for PR opensearch-project#8383 created/updated

0c5b90f

wanglam reviewed Sep 30, 2024

View reviewed changes

Kapian1234 added 2 commits September 30, 2024 13:54

resolve some issues

2165f38

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

merge from origin

bb2363e

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

wanglam reviewed Sep 30, 2024

View reviewed changes

update title style

3aeff67

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

ruanyl added backport 2.x workspace labels Sep 30, 2024

wanglam reviewed Sep 30, 2024

View reviewed changes

ruanyl previously approved these changes Sep 30, 2024

View reviewed changes

update title style

57bcdff

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

Kapian1234 dismissed ruanyl’s stale review via 57bcdff September 30, 2024 07:59

SuZhou-Joe reviewed Sep 30, 2024

View reviewed changes

src/plugins/workspace/public/components/workspace_form/workspace_permission_setting_input.tsx Outdated Show resolved Hide resolved

wanglam reviewed Sep 30, 2024

View reviewed changes

Kapian1234 added 3 commits September 30, 2024 17:31

update placeholder

892fe16

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

update placeholder

416d935

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

/

b768623

Signed-off-by: Kapian1234 <wanjinch@amazon.com>

ruanyl approved these changes Sep 30, 2024

View reviewed changes

wanglam approved these changes Sep 30, 2024

View reviewed changes

SuZhou-Joe approved these changes Sep 30, 2024

View reviewed changes

SuZhou-Joe merged commit 83d5fba into opensearch-project:main Sep 30, 2024
67 checks passed

opensearch-trigger-bot bot added the failed backport label Sep 30, 2024

SuZhou-Joe added backport 2.x and removed failed backport backport 2.x labels Oct 1, 2024

opensearch-project deleted a comment from opensearch-trigger-bot bot Oct 1, 2024

opensearch-trigger-bot bot mentioned this pull request Oct 1, 2024

[Backport 2.x] [Workspace] Refactor data source association panel #8419

Merged

ananzh added the v2.18.0 label Oct 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Workspace] Refactor data source association panel #8383

[Workspace] Refactor data source association panel #8383

Kapian1234 commented Sep 30, 2024 •

edited

Loading

wanglam Sep 30, 2024

Kapian1234 Sep 30, 2024

wanglam Sep 30, 2024

Kapian1234 Sep 30, 2024

wanglam Sep 30, 2024

Kapian1234 Sep 30, 2024

wanglam Sep 30, 2024 •

edited

Loading

Kapian1234 Sep 30, 2024

wanglam Sep 30, 2024 •

edited

Loading

Kapian1234 Sep 30, 2024 •

edited

Loading

wanglam Sep 30, 2024

Kapian1234 Sep 30, 2024

[Workspace] Refactor data source association panel #8383

[Workspace] Refactor data source association panel #8383

Conversation

Kapian1234 commented Sep 30, 2024 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wanglam Sep 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wanglam Sep 30, 2024 • edited Loading

Choose a reason for hiding this comment

Kapian1234 Sep 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kapian1234 commented Sep 30, 2024 •

edited

Loading

wanglam Sep 30, 2024 •

edited

Loading

wanglam Sep 30, 2024 •

edited

Loading

Kapian1234 Sep 30, 2024 •

edited

Loading