Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic uses of i18n and correct unprefixed and duplicate i18n identifiers in dataSourceManagement plugin #8394

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Oct 1, 2024

Description

Fix dynamic uses of i18n and correct unprefixed and duplicate i18n identifiers in dataSourceManagement plugin

Changelog

  • fix: Fix dynamic and correct unprefixed and duplicate i18n identifiers in dataSourceManagement plugin

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

github-actions bot commented Oct 1, 2024

❌ Entry Too Long

Entry is 110 characters long, which is 10 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.92%. Comparing base (a663a84) to head (1d2f7eb).
Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
...source_management/public/components/breadcrumbs.ts 0.00% 0 Missing and 3 partials ⚠️
...c/components/edit_data_source/edit_data_source.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8394   +/-   ##
=======================================
  Coverage   60.92%   60.92%           
=======================================
  Files        3750     3752    +2     
  Lines       89103    89135   +32     
  Branches    13925    13932    +7     
=======================================
+ Hits        54285    54306   +21     
- Misses      31442    31451    +9     
- Partials     3376     3378    +2     
Flag Coverage Δ
Linux_1 28.84% <0.00%> (+0.01%) ⬆️
Linux_2 56.35% <ø> (-0.01%) ⬇️
Linux_3 37.72% <81.81%> (-0.01%) ⬇️
Linux_4 29.95% <25.00%> (-0.01%) ⬇️
Windows_1 28.86% <0.00%> (+0.01%) ⬆️
Windows_2 56.30% <ø> (-0.01%) ⬇️
Windows_3 37.72% <81.81%> (-0.01%) ⬇️
Windows_4 29.95% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

opensearch-changeset-bot bot added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Oct 1, 2024
@ashwin-pc ashwin-pc added the i18n Internationalization related Issues and PRs label Oct 1, 2024
AMoo-Miki and others added 2 commits October 1, 2024 09:23
Copy link
Contributor

@RyanL1997 RyanL1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AMoo-Miki Thanks for taking this on. In generally looking good to me. In addition, could @BionIT check some of the Opensearch Connection related change?

@AMoo-Miki AMoo-Miki merged commit 9da5f9b into opensearch-project:main Oct 4, 2024
67 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8394-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9da5f9ba13807263c3bcb063d954ad8da2b0716d
# Push it to GitHub
git push --set-upstream origin backport/backport-8394-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8394-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8394-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9da5f9ba13807263c3bcb063d954ad8da2b0716d
# Push it to GitHub
git push --set-upstream origin backport/backport-8394-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8394-to-2.x.

AMoo-Miki added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Oct 7, 2024
…entifiers in dataSourceManagement plugin (opensearch-project#8394)

* Fix dynamic uses of i18n and correct unprefixed and duplicate i18n identifiers in dataSourceManagement plugin

Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR opensearch-project#8394 created/updated

---------

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

(cherry picked from commit 9da5f9b)
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki added a commit that referenced this pull request Oct 8, 2024
…entifiers in dataSourceManagement plugin (#8394) (#8516)

* Fix dynamic uses of i18n and correct unprefixed and duplicate i18n identifiers in dataSourceManagement plugin



* Changeset file for PR #8394 created/updated

---------




(cherry picked from commit 9da5f9b)

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x distinguished-contributor i18n Internationalization related Issues and PRs v2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants