Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect use of TopNavControlDescriptionData in dataSourceManagement plugin #8402

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Fix incorrect use of TopNavControlDescriptionData in dataSourceManagement plugin #8402

merged 2 commits into from
Oct 4, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

Description

Fix incorrect use of TopNavControlDescriptionData in dataSourceManagement plugin

Changelog

  • fix: Fix incorrect use of TopNavControlDescriptionData in dataSourceManagement plugin

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@AMoo-Miki
Fix incorrect use of TopNavControlDescriptionData in dataSourceManage…
521d445 
…ment plugin

Signed-off-by: Miki <miki@amazon.com>
@codecov Codecov
Copy link

codecov bot commented Oct 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.92%. Comparing base (a663a84) to head (1694760).
Report is 41 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8402      +/-   ##
==========================================
- Coverage   60.92%   60.92%   -0.01%     
==========================================
  Files        3750     3750              
  Lines       89103    89103              
  Branches    13925    13925              
==========================================
- Hits        54285    54283       -2     
- Misses      31442    31443       +1     
- Partials     3376     3377       +1
Flag Coverage Δ
Linux_1 28.83% <ø> (ø)
Linux_2 56.35% <ø> (ø)
Linux_3 37.72% <ø> (-0.01%) ⬇️
Linux_4 29.96% <ø> (ø)
Windows_1 28.84% <ø> (ø)
Windows_2 56.30% <ø> (ø)
Windows_3 37.72% <ø> (ø)
Windows_4 29.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashwin-pc ashwin-pc added the i18n Internationalization related Issues and PRs label Oct 1, 2024
seraphjiang
seraphjiang approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@seraphjiang seraphjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AMoo-Miki AMoo-Miki merged commit 0b7778b into opensearch-project:main Oct 4, 2024
73 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 4, 2024
@github-actions @opensearch-changeset-bot
Fix incorrect use of TopNavControlDescriptionData in dataSourceManage…
07fc2c7 
…ment plugin (#8402)

* Fix incorrect use of TopNavControlDescriptionData in dataSourceManagement plugin

Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR #8402 created/updated

---------

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 0b7778b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 4, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Oct 4, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
Fix incorrect use of TopNavControlDescriptionData in dataSourceManage…
bf3f20d 
…ment plugin (#8402) (#8482)

* Fix incorrect use of TopNavControlDescriptionData in dataSourceManagement plugin



* Changeset file for PR #8402 created/updated

---------



(cherry picked from commit 0b7778b)

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hailong-am Hailong-am Hailong-am approved these changes

@BionIT BionIT BionIT approved these changes

@seraphjiang seraphjiang seraphjiang approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees

@BionIT BionIT

@mengweieric mengweieric

Labels
backport 2.x distinguished-contributor i18n Internationalization related Issues and PRs v2.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AMoo-Miki @seraphjiang @BionIT @Hailong-am @ashwin-pc @mengweieric