-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace]Fix use case hidden features not accessible #8445
[Workspace]Fix use case hidden features not accessible #8445
Conversation
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8445 +/- ##
=======================================
Coverage 60.95% 60.95%
=======================================
Files 3758 3758
Lines 89288 89305 +17
Branches 13970 13972 +2
=======================================
+ Hits 54422 54437 +15
- Misses 31478 31479 +1
- Partials 3388 3389 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/plugins/workspace/public/components/workspace_form/workspace_use_case_flyout.tsx
Outdated
Show resolved
Hide resolved
…ce_use_case_flyout.tsx Co-authored-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Lin Wang <wonglam@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8445-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 638f753241dc0eccb089e3225e7a574ee41355a0
# Push it to GitHub
git push --set-upstream origin backport/backport-8445-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
backport depends on #8444 to be merged first |
* Fix use case hidden features not accessible Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR #8445 created/updated * Change to useCaseWithDisplayedFeatures Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove not used import Signed-off-by: Lin Wang <wonglam@amazon.com> * Update src/plugins/workspace/public/components/workspace_form/workspace_use_case_flyout.tsx Co-authored-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit 638f753) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix use case hidden features not accessible * Changeset file for PR #8445 created/updated * Change to useCaseWithDisplayedFeatures * Remove not used import * Update src/plugins/workspace/public/components/workspace_form/workspace_use_case_flyout.tsx --------- (cherry picked from commit 638f753) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <amoo_miki@yahoo.com>
…oject#8445) (opensearch-project#8459) * Fix use case hidden features not accessible * Changeset file for PR opensearch-project#8445 created/updated * Change to useCaseWithDisplayedFeatures * Remove not used import * Update src/plugins/workspace/public/components/workspace_form/workspace_use_case_flyout.tsx --------- (cherry picked from commit 638f753) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <amoo_miki@yahoo.com>
Description
This PR is for fixing hidden features not accessible due to #8413 . The use case selector refactor PR modified the features array and removed features not displayed in the flyout. These features should be accessed even they not displayed in the use case flyout (such as: getting started, overview, all custom features).
Screenshot
No UI Changes.
Testing the changes
yarn osd bootstrap --single-version loose
config/opensearch_dashboards.yml
yarn start --no-base-path
Changelog
Check List
yarn test:jest
yarn test:jest_integration