Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]Fix use case hidden features not accessible #8445

Conversation

wanglam
Copy link
Contributor

@wanglam wanglam commented Oct 2, 2024

Description

This PR is for fixing hidden features not accessible due to #8413 . The use case selector refactor PR modified the features array and removed features not displayed in the flyout. These features should be accessed even they not displayed in the use case flyout (such as: getting started, overview, all custom features).

Screenshot

No UI Changes.

Testing the changes

  • Clone branch code and run yarn osd bootstrap --single-version loose
  • Add below configs in config/opensearch_dashboards.yml
savedObjects.permission.enabled: true
workspace.enabled: true
uiSettings:
  overrides:
    'home:useNewHomePage': true
opensearchDashboards.dashboardAdmin.users: ['admin']

Changelog

  • fix: [Workspace]Fix use case hidden features not accessible

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lin Wang <wonglam@amazon.com>
opensearch-changeset-bot bot and others added 3 commits October 2, 2024 11:01
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 97.87234% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.95%. Comparing base (db7d354) to head (4ec5b90).
Report is 122 commits behind head on main.

Files with missing lines Patch % Lines
...nents/workspace_form/workspace_use_case_flyout.tsx 97.61% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8445   +/-   ##
=======================================
  Coverage   60.95%   60.95%           
=======================================
  Files        3758     3758           
  Lines       89288    89305   +17     
  Branches    13970    13972    +2     
=======================================
+ Hits        54422    54437   +15     
- Misses      31478    31479    +1     
- Partials     3388     3389    +1     
Flag Coverage Δ
Linux_1 28.91% <97.87%> (+0.01%) ⬆️
Linux_2 56.35% <ø> (ø)
Linux_3 37.78% <ø> (-0.01%) ⬇️
Linux_4 29.95% <ø> (ø)
Windows_1 28.92% <97.87%> (+0.01%) ⬆️
Windows_2 56.31% <ø> (ø)
Windows_3 37.78% <ø> (ø)
Windows_4 29.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wanglam and others added 2 commits October 3, 2024 08:56
…ce_use_case_flyout.tsx

Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
@Hailong-am Hailong-am merged commit 638f753 into opensearch-project:main Oct 3, 2024
70 of 71 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8445-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 638f753241dc0eccb089e3225e7a574ee41355a0
# Push it to GitHub
git push --set-upstream origin backport/backport-8445-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8445-to-2.x.

@Hailong-am
Copy link
Collaborator

backport depends on #8444 to be merged first

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 3, 2024
* Fix use case hidden features not accessible

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Changeset file for PR #8445 created/updated

* Change to useCaseWithDisplayedFeatures

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Remove not used import

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Update src/plugins/workspace/public/components/workspace_form/workspace_use_case_flyout.tsx

Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit 638f753)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am pushed a commit that referenced this pull request Oct 3, 2024
* Fix use case hidden features not accessible



* Changeset file for PR #8445 created/updated

* Change to useCaseWithDisplayedFeatures



* Remove not used import



* Update src/plugins/workspace/public/components/workspace_form/workspace_use_case_flyout.tsx




---------




(cherry picked from commit 638f753)

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 3, 2024
…oject#8445) (opensearch-project#8459)

* Fix use case hidden features not accessible



* Changeset file for PR opensearch-project#8445 created/updated

* Change to useCaseWithDisplayedFeatures



* Remove not used import



* Update src/plugins/workspace/public/components/workspace_form/workspace_use_case_flyout.tsx




---------




(cherry picked from commit 638f753)

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
@ananzh ananzh added the v2.18.0 label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants