Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]Remove workspace name populate after use case selected #8484

Conversation

wanglam
Copy link
Contributor

@wanglam wanglam commented Oct 4, 2024

Description

This PR include two changes in workspace use case selector.

  1. Remove the workspace name populated logic after use case selected
  2. Reduce gaps between use case cards

Screenshot

image

Testing the changes

  • Clone branch code and run yarn osd bootstrap --single-version loose
  • Add below configs in config/opensearch_dashboards.yml
savedObjects.permission.enabled: true
workspace.enabled: true
uiSettings:
  overrides:
    'home:useNewHomePage': true
opensearchDashboards.dashboardAdmin.users: ['admin']
  • Run yarn start --no-base-path
  • Login with admin user and go to workspace create page by bottom left menu
  • The use case selector should displayed like screenshot above
  • The workspace name should be be populated after use case changed

Changelog

  • feat: [Workspace]Remove workspace name populate after use case selected

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Copy link
Contributor

github-actions bot commented Oct 4, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.93%. Comparing base (9da5f9b) to head (0957170).
Report is 107 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8484      +/-   ##
==========================================
- Coverage   60.93%   60.93%   -0.01%     
==========================================
  Files        3760     3760              
  Lines       89310    89301       -9     
  Branches    13970    13969       -1     
==========================================
- Hits        54423    54414       -9     
  Misses      31492    31492              
  Partials     3395     3395              
Flag Coverage Δ
Linux_1 28.90% <ø> (-0.01%) ⬇️
Linux_2 56.30% <ø> (ø)
Linux_3 37.76% <ø> (ø)
Linux_4 29.93% <ø> (ø)
Windows_1 28.92% <ø> (-0.01%) ⬇️
Windows_2 56.25% <ø> (ø)
Windows_3 37.76% <ø> (ø)
Windows_4 29.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 858b70f into opensearch-project:main Oct 4, 2024
70 of 71 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 4, 2024
)

* Remove workspace name update logic after use case select

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Reduce gap between use case cards

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Changeset file for PR #8484 created/updated

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 858b70f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Oct 4, 2024
) (#8488)

* Remove workspace name update logic after use case select



* Reduce gap between use case cards



* Changeset file for PR #8484 created/updated

---------



(cherry picked from commit 858b70f)

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@ananzh ananzh added the v2.18.0 label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants