feat: introducing workspace level ui settings and hide non-global ui settings from advance settings page #8500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ui settings from advance settings page + make defaultIndex pattern a workspace ui setting when workspace is on and make it a global setting when workspace is off Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8500 +/- ##
=======================================
Coverage 60.95% 60.95%
=======================================
Files 3766 3768 +2
Lines 89364 89396 +32
Branches 13978 13981 +3
=======================================
+ Hits 54468 54492 +24
- Misses 31498 31506 +8
Partials 3398 3398
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
previously approved these changes
Oct 7, 2024
|
CI failed, not sure if related. |
…vance-setting-page
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe
approved these changes
Oct 8, 2024
Hailong-am
approved these changes
Oct 9, 2024
Comment on lines
+37
to
+40
| // cannot import from core/server due to src/core/server/saved_objects/opensearch_query.js which | ||
| // export { opensearchKuery } from '../../../plugins/data/server'; | ||
| // eslint-disable-next-line @osd/eslint/no-restricted-paths | ||
| import { UiSettingScope } from '../../../core/server/ui_settings/types'; |
There was a problem hiding this comment.
will this impacts build?
There was a problem hiding this comment.
No. Actually, if importing from core/server, it only affects the unit tests in create_or_upgrade_saved_config.test.ts
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
…settings from advance settings page (#8500) * feat: introducing workspace level ui settings and hide non-global ui settings from advance settings page + make defaultIndex pattern a workspace ui setting when workspace is on and make it a global setting when workspace is off Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * Changeset file for PR #8500 created/updated * fix: failed tests Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * fix: lint Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 91fd6d3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Oct 11, 2024
…settings from advance settings page (#8500) (#8539) * feat: introducing workspace level ui settings and hide non-global ui settings from advance settings page + make defaultIndex pattern a workspace ui setting when workspace is on and make it a global setting when workspace is off --------- (cherry picked from commit 91fd6d3) Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 30, 2024
…settings from advance settings page (opensearch-project#8500) * feat: introducing workspace level ui settings and hide non-global ui settings from advance settings page + make defaultIndex pattern a workspace ui setting when workspace is on and make it a global setting when workspace is off Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * Changeset file for PR opensearch-project#8500 created/updated * fix: failed tests Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * fix: lint Signed-off-by: Yulong Ruan <ruanyl@amazon.com> --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UI changes:
Make
defaultIndexpattern a workspace ui setting when workspace is on and make it a global setting when workspace is offIssues Resolved
Screenshot
Workspace disabled:
Workspace enabled:
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration