Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]Analytics use case overview and essential use case overview crashed #8524

Merged

Conversation

wanglam
Copy link
Contributor

@wanglam wanglam commented Oct 8, 2024

Description

This PR is for fixing page crashed in the analytics use case overview and essential use case overview. The root cause was using this inside a normal function. Since use case overview page doesn't need collaboratorTypes service, just remove it from the depend services list.

Testing the changes

  • Clone branch code and run yarn osd bootstrap --single-version loose
  • Add below configs in config/opensearch_dashboards.yml
savedObjects.permission.enabled: true
workspace.enabled: true
uiSettings:
  overrides:
    'home:useNewHomePage': true
opensearchDashboards.dashboardAdmin.users: ['admin']
  • Run yarn start --no-base-path
  • Login with admin user
  • Go to analytics use case overview page, page should not crashed
  • Go to essential use case overview page, page should not crashed

Changelog

  • fix: [Workspace]Analytics use case overview and essential use case overview crashed

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lin Wang <wonglam@amazon.com>
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.93%. Comparing base (61eedf7) to head (d3d74fe).
Report is 93 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8524   +/-   ##
=======================================
  Coverage   60.93%   60.93%           
=======================================
  Files        3767     3767           
  Lines       89406    89406           
  Branches    13994    13994           
=======================================
+ Hits        54478    54480    +2     
+ Misses      31526    31525    -1     
+ Partials     3402     3401    -1     
Flag Coverage Δ
Linux_1 28.96% <ø> (ø)
Linux_2 56.25% <ø> (ø)
Linux_3 37.75% <ø> (+<0.01%) ⬆️
Linux_4 29.91% <ø> (ø)
Windows_1 28.97% <ø> (ø)
Windows_2 56.20% <ø> (ø)
Windows_3 37.75% <ø> (ø)
Windows_4 29.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit acc947e into opensearch-project:main Oct 8, 2024
74 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 8, 2024
…w crashed (#8524)

* Remove collaboratorTypes in renderUseCaseOverviewApp

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Changeset file for PR #8524 created/updated

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit acc947e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Oct 8, 2024
@ananzh ananzh added the v2.18.0 label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants