-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace]Replace connections copy with data sources #8540
Merged
SuZhou-Joe
merged 6 commits into
opensearch-project:main
from
wanglam:replace-connections-with-data-sources
Oct 12, 2024
Merged
[Workspace]Replace connections copy with data sources #8540
SuZhou-Joe
merged 6 commits into
opensearch-project:main
from
wanglam:replace-connections-with-data-sources
Oct 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <wonglam@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8540 +/- ##
=======================================
Coverage 60.93% 60.93%
=======================================
Files 3777 3777
Lines 89852 89852
Branches 14086 14086
=======================================
+ Hits 54750 54752 +2
+ Misses 31668 31667 -1
+ Partials 3434 3433 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lin Wang <wonglam@amazon.com>
wanglam
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
October 10, 2024 05:34
Hailong-am
approved these changes
Oct 11, 2024
SuZhou-Joe
approved these changes
Oct 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 12, 2024
* Replace connections copy with data sources Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR #8540 created/updated * Fix failed unit tests Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 841170b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Replace connections copy with data sources * Changeset file for PR #8540 created/updated * Fix failed unit tests --------- (cherry picked from commit 841170b) Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sejli
pushed a commit
to sejli/OpenSearch-Dashboards
that referenced
this pull request
Oct 21, 2024
…ject#8540) * Replace connections copy with data sources Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR opensearch-project#8540 created/updated * Fix failed unit tests Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 30, 2024
…ject#8540) * Replace connections copy with data sources Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR opensearch-project#8540 created/updated * Fix failed unit tests Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for replacing "connection" copy with "data sources" in workspace creation page like screenshots below.
Screenshot
Testing the changes
yarn osd bootstrap --single-version loose
config/opensearch_dashboards.yml
yarn start --no-base-path
Changelog
Check List
yarn test:jest
yarn test:jest_integration