Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]Replace connections copy with data sources #8540

Conversation

wanglam
Copy link
Contributor

@wanglam wanglam commented Oct 10, 2024

Description

This PR is for replacing "connection" copy with "data sources" in workspace creation page like screenshots below.

Screenshot

image
image
image

Testing the changes

  • Clone branch code and run yarn osd bootstrap --single-version loose
  • Add below configs in config/opensearch_dashboards.yml
savedObjects.permission.enabled: true
workspace.enabled: true
uiSettings:
  overrides:
    'home:useNewHomePage': true
opensearchDashboards.dashboardAdmin.users: ['admin']
  • Run yarn start --no-base-path
  • Login with admin user and go to workspace create page by bottom left menu
  • Scroll to the "Add data sources" section should show "data sources" instead "connections"
  • Click "Add OpenSearch data sources" should show modal like screenshots above
  • Click "Add Direct query data sources" should show modal like screenshots above

Changelog

  • feat: [Workspace]Replace connections copy with data sources

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lin Wang <wonglam@amazon.com>
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.93%. Comparing base (fc03639) to head (74533e4).
Report is 76 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8540   +/-   ##
=======================================
  Coverage   60.93%   60.93%           
=======================================
  Files        3777     3777           
  Lines       89852    89852           
  Branches    14086    14086           
=======================================
+ Hits        54750    54752    +2     
+ Misses      31668    31667    -1     
+ Partials     3434     3433    -1     
Flag Coverage Δ
Linux_1 29.15% <ø> (ø)
Linux_2 56.28% <ø> (ø)
Linux_3 37.81% <ø> (+<0.01%) ⬆️
Linux_4 29.95% <ø> (ø)
Windows_1 29.16% <ø> (ø)
Windows_2 56.23% <ø> (ø)
Windows_3 37.81% <ø> (ø)
Windows_4 29.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Lin Wang <wonglam@amazon.com>
@SuZhou-Joe SuZhou-Joe merged commit 841170b into opensearch-project:main Oct 12, 2024
66 of 68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 12, 2024
* Replace connections copy with data sources

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Changeset file for PR #8540 created/updated

* Fix failed unit tests

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 841170b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am pushed a commit that referenced this pull request Oct 14, 2024
* Replace connections copy with data sources



* Changeset file for PR #8540 created/updated

* Fix failed unit tests



---------



(cherry picked from commit 841170b)

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sejli pushed a commit to sejli/OpenSearch-Dashboards that referenced this pull request Oct 21, 2024
…ject#8540)

* Replace connections copy with data sources

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Changeset file for PR opensearch-project#8540 created/updated

* Fix failed unit tests

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Oct 30, 2024
…ject#8540)

* Replace connections copy with data sources

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Changeset file for PR opensearch-project#8540 created/updated

* Fix failed unit tests

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@ananzh ananzh added the v2.18.0 label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants