[Workspace] Disable copy all button when there is no saved objects in assets page #8581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yubonluo <yubonluo@amazon.com>
yubonluo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
SuZhou-Joe
previously approved these changes
Oct 14, 2024
|
It seems we only disable the button instead of fixing the root cause. Can we fix the place giving the error? |
wanglam
reviewed
Oct 14, 2024
| @@ -91,7 +91,7 @@ export class DuplicateResultFlyout extends React.Component<DuplicateResultFlyout | |||
| {copiedCount && ( | |||
| <EuiFlexItem grow={false}> | |||
| <EuiTitle size="xs"> | |||
| <h4 className="savedObjectsManagementImportSummary__copiedCountCount"> | |||
| <h4 className="savedObjectsManagementImportSummary__createdCount"> | |||
There was a problem hiding this comment.
Nit: This change does not seem related to the copy issue, was it made intentionally?
There was a problem hiding this comment.
When user copy saved objects successfully, we should show the correct color:
The previous classname is wrong and shows black.
wanglam
approved these changes
Oct 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8581 +/- ##
==========================================
- Coverage 60.92% 60.89% -0.03%
==========================================
Files 3777 3786 +9
Lines 89847 90120 +273
Branches 14083 14128 +45
==========================================
+ Hits 54738 54883 +145
- Misses 31673 31794 +121
- Partials 3436 3443 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: yubonluo <yubonluo@amazon.com>
…Dashboards into 2.17/fix-copy-issue
Sure, the root cause is when selectedObjectCount is 0, we can not get the |
SuZhou-Joe
changed the title
SuZhou-Joe
approved these changes
Oct 14, 2024
Hailong-am
approved these changes
Oct 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
… assets page (#8581) * fix copy issue Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #8581 created/updated * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 4334ecf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Oct 15, 2024
… assets page (#8581) (#8590) * fix copy issue * Changeset file for PR #8581 created/updated * optimize the code --------- (cherry picked from commit 4334ecf) Signed-off-by: yubonluo <yubonluo@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sejli
pushed a commit
to sejli/OpenSearch-Dashboards
that referenced
this pull request
Oct 21, 2024
… assets page (opensearch-project#8581) * fix copy issue Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR opensearch-project#8581 created/updated * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 30, 2024
… assets page (opensearch-project#8581) * fix copy issue Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR opensearch-project#8581 created/updated * optimize the code Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Page crashed after click "Copy assets to ..." button in workspace assets page when assets table is empty
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration