[Workspace] feat: add workspace collaborators page #8594

raintygao · 2024-10-15T08:42:47Z

Description

feat: add workspace collaborators page

Screenshot

Testing the changes

Go to workspace collaborator page(http://localhost:6601/w/{workspace_id}/app/collaborators) then see the changes.

Changelog

feat: Add workspace collaborators page

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

codecov · 2024-10-15T09:19:30Z

Codecov Report

Attention: Patch coverage is 62.71186% with 22 lines in your changes missing coverage. Please review.

Project coverage is 60.95%. Comparing base (5c8b2e3) to head (4d9b19b).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...ts/workspace_form/workspace_collaborator_table.tsx	28.57%	9 Missing and 1 partial ⚠️
...orkspace_collaborators/workspace_collaborators.tsx	78.26%	3 Missing and 2 partials ⚠️
...ponents/workspace_form/add_collaborator_button.tsx	50.00%	2 Missing and 1 partial ⚠️
src/plugins/workspace/public/plugin.ts	62.50%	3 Missing ⚠️
...gins/workspace/public/services/use_case_service.ts	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8594   +/-   ##
=======================================
  Coverage   60.94%   60.95%           
=======================================
  Files        3790     3792    +2     
  Lines       90306    90355   +49     
  Branches    14154    14170   +16     
=======================================
+ Hits        55034    55072   +38     
- Misses      31815    31822    +7     
- Partials     3457     3461    +4

Flag	Coverage Δ
Linux_1	`29.32% <62.71%> (+0.03%)`	⬆️
Linux_2	`56.39% <ø> (ø)`
Linux_3	`37.71% <ø> (+<0.01%)`	⬆️
Linux_4	`29.91% <ø> (ø)`
Windows_1	`29.34% <62.71%> (+0.03%)`	⬆️
Windows_2	`56.34% <ø> (ø)`
Windows_3	`37.71% <ø> (ø)`
Windows_4	`29.91% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/plugins/workspace/public/components/workspace_collaborators/workspace_collaborators.tsx

src/plugins/workspace/public/components/workspace_form/add_collaborator_button.tsx

src/plugins/workspace/public/components/workspace_form/workspace_collaborator_table.tsx

Hailong-am · 2024-10-17T03:27:40Z

buttons on both left and right are larger than search bar

Hailong-am · 2024-10-17T03:30:23Z

src/plugins/workspace/public/components/workspace_form/workspace_collaborator_table.tsx

@@ -309,20 +327,25 @@ export const WorkspaceCollaboratorTable = ({
    {
      field: 'primaryId',
      name: 'ID',
+      width: '30%',
    },
    {
      field: 'displayedType',
      name: 'Type',


i18 for name and other columns

Signed-off-by: tygao <tygao@amazon.com>

SuZhou-Joe · 2024-10-17T08:55:27Z

src/plugins/workspace/public/components/workspace_form/workspace_collaborator_table.tsx

+          const result = await handleSubmitPermissionSettings(
+            newSettings as WorkspacePermissionSetting[]
+          );
+          if (result?.success) {


Do we need to show error toast if result.success is false?

* init collaborator page Signed-off-by: tygao <tygao@amazon.com> * not register when permission is disabled Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR #8594 created/updated * Changeset file for PR #8594 created/updated * use select in i18n statement Signed-off-by: tygao <tygao@amazon.com> * test: update tests Signed-off-by: tygao <tygao@amazon.com> * add partial test cases Signed-off-by: tygao <tygao@amazon.com> * test: update tests Signed-off-by: tygao <tygao@amazon.com> * use i18n to wrap Signed-off-by: tygao <tygao@amazon.com> * update button style Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 4a2416f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* init collaborator page * not register when permission is disabled * Changeset file for PR #8594 created/updated * Changeset file for PR #8594 created/updated * use select in i18n statement * test: update tests * add partial test cases * test: update tests * use i18n to wrap * update button style --------- (cherry picked from commit 4a2416f) Signed-off-by: tygao <tygao@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…t#8594) * init collaborator page Signed-off-by: tygao <tygao@amazon.com> * not register when permission is disabled Signed-off-by: tygao <tygao@amazon.com> * Changeset file for PR opensearch-project#8594 created/updated * Changeset file for PR opensearch-project#8594 created/updated * use select in i18n statement Signed-off-by: tygao <tygao@amazon.com> * test: update tests Signed-off-by: tygao <tygao@amazon.com> * add partial test cases Signed-off-by: tygao <tygao@amazon.com> * test: update tests Signed-off-by: tygao <tygao@amazon.com> * use i18n to wrap Signed-off-by: tygao <tygao@amazon.com> * update button style Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

github-actions bot added the all-star-contributor label Oct 15, 2024

opensearch-changeset-bot bot added a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Oct 15, 2024

Changeset file for PR opensearch-project#8594 created/updated

b7ebb81

raintygao force-pushed the colla branch from b7ebb81 to 245419c Compare October 15, 2024 08:45

opensearch-changeset-bot bot added a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Oct 15, 2024

Changeset file for PR opensearch-project#8594 created/updated

4b6af59

opensearch-changeset-bot bot added a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Oct 15, 2024

Changeset file for PR opensearch-project#8594 created/updated

5613fa8

raintygao pushed a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Oct 16, 2024

Changeset file for PR opensearch-project#8594 created/updated

28600b3

raintygao pushed a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Oct 16, 2024

Changeset file for PR opensearch-project#8594 created/updated

2bf00bf

raintygao force-pushed the colla branch from a317367 to 73b4c99 Compare October 16, 2024 14:39

Hailong-am reviewed Oct 17, 2024

View reviewed changes

raintygao and others added 9 commits October 17, 2024 13:41

init collaborator page

729bade

Signed-off-by: tygao <tygao@amazon.com>

not register when permission is disabled

e13e283

Signed-off-by: tygao <tygao@amazon.com>

Changeset file for PR opensearch-project#8594 created/updated

a62da3a

Changeset file for PR opensearch-project#8594 created/updated

0403f44

use select in i18n statement

b4c9502

Signed-off-by: tygao <tygao@amazon.com>

test: update tests

d14f997

Signed-off-by: tygao <tygao@amazon.com>

add partial test cases

625b54d

Signed-off-by: tygao <tygao@amazon.com>

test: update tests

590f395

Signed-off-by: tygao <tygao@amazon.com>

use i18n to wrap

4646916

Signed-off-by: tygao <tygao@amazon.com>

raintygao force-pushed the colla branch from cff13d5 to 4646916 Compare October 17, 2024 06:23

update button style

4d9b19b

Signed-off-by: tygao <tygao@amazon.com>

Hailong-am previously approved these changes Oct 17, 2024

View reviewed changes

raintygao dismissed Hailong-am’s stale review via 4d9b19b October 17, 2024 06:42

Hailong-am approved these changes Oct 17, 2024

View reviewed changes

SuZhou-Joe reviewed Oct 17, 2024

View reviewed changes

SuZhou-Joe approved these changes Oct 17, 2024

View reviewed changes

SuZhou-Joe merged commit 4a2416f into opensearch-project:main Oct 17, 2024
68 checks passed

opensearch-trigger-bot bot mentioned this pull request Oct 17, 2024

[Backport 2.x] [Workspace] feat: add workspace collaborators page #8623

Merged

wanglam mentioned this pull request Oct 18, 2024

[Workspace]Disable confirm button during collaborators operation #8604

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Workspace] feat: add workspace collaborators page #8594

[Workspace] feat: add workspace collaborators page #8594

raintygao commented Oct 15, 2024 •

edited

Loading

codecov bot commented Oct 15, 2024 •

edited

Loading

Hailong-am commented Oct 17, 2024

Hailong-am Oct 17, 2024

SuZhou-Joe Oct 17, 2024

[Workspace] feat: add workspace collaborators page #8594

[Workspace] feat: add workspace collaborators page #8594

Conversation

raintygao commented Oct 15, 2024 • edited Loading

Description

Screenshot

Testing the changes

Changelog

Check List

codecov bot commented Oct 15, 2024 • edited Loading

Codecov Report

Hailong-am commented Oct 17, 2024

Hailong-am Oct 17, 2024

Choose a reason for hiding this comment

SuZhou-Joe Oct 17, 2024

Choose a reason for hiding this comment

raintygao commented Oct 15, 2024 •

edited

Loading

codecov bot commented Oct 15, 2024 •

edited

Loading