Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Fix content management render dashboard with duplicate visualizations #8606

Merged

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Oct 16, 2024

Description

Fix content management render dashboard with duplicate visualizations

Issues Resolved

#8605

Screenshot

Before
image

After

image

Testing the changes

Changelog

  • fix: [workspace]fix content management render dashboard with duplicate visualizations

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Hailong Cui <ihailong@amazon.com>
@Hailong-am Hailong-am changed the title [Workspace] Fix content management can't render dashboard with duplicate visualizations [Workspace] Fix content management render dashboard with duplicate visualizations Oct 16, 2024
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.95%. Comparing base (5c8b2e3) to head (600a546).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...tent_management/public/components/section_input.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8606      +/-   ##
==========================================
+ Coverage   60.94%   60.95%   +0.01%     
==========================================
  Files        3790     3790              
  Lines       90306    90307       +1     
  Branches    14154    14155       +1     
==========================================
+ Hits        55034    55046      +12     
+ Misses      31815    31803      -12     
- Partials     3457     3458       +1     
Flag Coverage Δ
Linux_1 29.29% <0.00%> (-0.01%) ⬇️
Linux_2 56.39% <ø> (ø)
Linux_3 37.71% <50.00%> (-0.01%) ⬇️
Linux_4 29.91% <0.00%> (-0.01%) ⬇️
Windows_1 29.32% <0.00%> (+0.01%) ⬆️
Windows_2 56.34% <ø> (ø)
Windows_3 37.71% <50.00%> (-0.01%) ⬇️
Windows_4 29.91% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 527ebb6 into opensearch-project:main Oct 17, 2024
66 of 68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 17, 2024
…sualizations (#8606)

* fix content managment can't render dashboard with duplicate viualization

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Changeset file for PR #8606 created/updated

* Changeset file for PR #8606 created/updated

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 527ebb6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Oct 17, 2024
…sualizations (#8606) (#8629)

* fix content managment can't render dashboard with duplicate viualization



* Changeset file for PR #8606 created/updated

* Changeset file for PR #8606 created/updated

---------



(cherry picked from commit 527ebb6)

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/OpenSearch-Dashboards that referenced this pull request Oct 19, 2024
…sualizations (opensearch-project#8606)

* fix content managment can't render dashboard with duplicate viualization

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Changeset file for PR opensearch-project#8606 created/updated

* Changeset file for PR opensearch-project#8606 created/updated

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sejli pushed a commit to sejli/OpenSearch-Dashboards that referenced this pull request Oct 21, 2024
…sualizations (opensearch-project#8606)

* fix content managment can't render dashboard with duplicate viualization

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Changeset file for PR opensearch-project#8606 created/updated

* Changeset file for PR opensearch-project#8606 created/updated

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Oct 30, 2024
…sualizations (opensearch-project#8606)

* fix content managment can't render dashboard with duplicate viualization

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* Changeset file for PR opensearch-project#8606 created/updated

* Changeset file for PR opensearch-project#8606 created/updated

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants