[Workspace] Limit workspace colors #8607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
Kapian1234
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Hailong-am
reviewed
Oct 16, 2024
| @@ -129,6 +129,7 @@ export const WorkspaceDetailFormDetails = ({ | |||
| error={formErrors.color?.message} | |||
| > | |||
| <EuiCompressedColorPicker | |||
| mode="swatch" | |||
| color={formData.color} | |||
There was a problem hiding this comment.
This still allow user to type whatever color they want
There was a problem hiding this comment.
Maybe we could add a rule for color validation when submitting like this: euiPaletteColorBlind().includes(color)
There was a problem hiding this comment.
should we use same component as create page? for now they are different.
There was a problem hiding this comment.
I‘ve tried the validation and it works on both the create page and the detail page
|
do we need to add validation at api side? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8607 +/- ##
==========================================
- Coverage 60.95% 60.94% -0.01%
==========================================
Files 3790 3790
Lines 90296 90306 +10
Branches 14151 14154 +3
==========================================
- Hits 55036 55034 -2
- Misses 31804 31815 +11
- Partials 3456 3457 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kapian1234 <wanjinch@amazon.com>
…arch-Dashboards into limit_workspace_colors
Hailong-am
approved these changes
Oct 17, 2024
| @@ -335,11 +335,11 @@ export const validateWorkspaceForm = ( | |||
| }), | |||
| }; | |||
| } | |||
| if (color && !validateWorkspaceColor(color)) { | |||
| if (color && (!validateWorkspaceColor(color) || !euiPaletteColorBlind().includes(color))) { | |||
There was a problem hiding this comment.
nit: Since we have this !euiPaletteColorBlind().includes(color) check which inlcudes the logic for !validateWorkspaceColor(color), we can remove !validateWorkspaceColor(color).
SuZhou-Joe
approved these changes
Oct 17, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
* Limit workspace color Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Limit workspace color at detail page Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Changeset file for PR #8607 created/updated * Add validation Signed-off-by: Kapian1234 <wanjinch@amazon.com> --------- Signed-off-by: Kapian1234 <wanjinch@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 2b3fbf0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Oct 17, 2024
* Limit workspace color * Limit workspace color at detail page * Changeset file for PR #8607 created/updated * Add validation --------- (cherry picked from commit 2b3fbf0) Signed-off-by: Kapian1234 <wanjinch@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
amsiglan
pushed a commit
to amsiglan/OpenSearch-Dashboards
that referenced
this pull request
Oct 19, 2024
* Limit workspace color Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Limit workspace color at detail page Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Changeset file for PR opensearch-project#8607 created/updated * Add validation Signed-off-by: Kapian1234 <wanjinch@amazon.com> --------- Signed-off-by: Kapian1234 <wanjinch@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
sejli
pushed a commit
to sejli/OpenSearch-Dashboards
that referenced
this pull request
Oct 21, 2024
* Limit workspace color Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Limit workspace color at detail page Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Changeset file for PR opensearch-project#8607 created/updated * Add validation Signed-off-by: Kapian1234 <wanjinch@amazon.com> --------- Signed-off-by: Kapian1234 <wanjinch@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 30, 2024
* Limit workspace color Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Limit workspace color at detail page Signed-off-by: Kapian1234 <wanjinch@amazon.com> * Changeset file for PR opensearch-project#8607 created/updated * Add validation Signed-off-by: Kapian1234 <wanjinch@amazon.com> --------- Signed-off-by: Kapian1234 <wanjinch@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Limit workspace colors to just those in color picker swatch.
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration