-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contentManagement): expose page API to allow remove section #8624
feat(contentManagement): expose page API to allow remove section #8624
Conversation
remove unnecessary space if card section title is not shown Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8624 +/- ##
==========================================
+ Coverage 60.94% 60.96% +0.02%
==========================================
Files 3790 3792 +2
Lines 90306 90358 +52
Branches 14154 14170 +16
==========================================
+ Hits 55034 55084 +50
+ Misses 31815 31812 -3
- Partials 3457 3462 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* feat(contentManagement): expose page API to allow remove section remove unnecessary space if card section title is not shown Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * Changeset file for PR #8624 created/updated --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 650166d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…nsearch-project#8624) * feat(contentManagement): expose page API to allow remove section remove unnecessary space if card section title is not shown Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * Changeset file for PR opensearch-project#8624 created/updated --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…nsearch-project#8624) * feat(contentManagement): expose page API to allow remove section remove unnecessary space if card section title is not shown Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * Changeset file for PR opensearch-project#8624 created/updated --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
…nsearch-project#8624) * feat(contentManagement): expose page API to allow remove section remove unnecessary space if card section title is not shown Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * Changeset file for PR opensearch-project#8624 created/updated --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
<OuiSpace />
if card section title is not shownScreen.Recording.2024-10-17.at.11.37.56.mov
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration