Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for async ppl to discover #8706

Merged
merged 7 commits into from
Oct 30, 2024

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Oct 25, 2024

Description

Add support for async ppl to discover

Issues Resolved

  • Adds PPL async search route
  • Update default query for ppl to source = ${dataset.title} | head 10
  • Adds PPL async search strategy
  • TODO as fast follow: check/remove time filter support

Screenshot

discover-ppl-flint.mov

Changelog

  • feat: Add support for async ppl to discover

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48 ps48 changed the title [WIP] Add support for async ppl to discover Add support for async ppl to discover Oct 28, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.75%. Comparing base (2f31914) to head (635b687).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8706   +/-   ##
=======================================
  Coverage   60.74%   60.75%           
=======================================
  Files        3798     3798           
  Lines       90685    90685           
  Branches    14272    14272           
=======================================
+ Hits        55091    55093    +2     
- Misses      32095    32139   +44     
+ Partials     3499     3453   -46     
Flag Coverage Δ
Linux_1 29.06% <ø> (ø)
Linux_2 56.39% <ø> (ø)
Linux_3 37.60% <ø> (ø)
Linux_4 29.82% <100.00%> (ø)
Windows_1 29.07% <ø> (ø)
Windows_2 56.34% <ø> (ø)
Windows_3 37.60% <ø> (ø)
Windows_4 29.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ps48 added 3 commits October 29, 2024 17:47
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm me! awesome! idk why the ci failed like twice specifically for this pr but i dont see any reason for this pr so it might be due to github.

@ananzh ananzh added the v2.19.0 label Oct 30, 2024
Copy link
Member

@sejli sejli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

One question I have is regarding aggregations support: Should async PPL support timefields/histogram? The ppl_async_search_strategy mimics the sql_async_search_strategy, which doesn't have histogram support.

@ps48
Copy link
Member Author

ps48 commented Oct 30, 2024

Looks good to me!

One question I have is regarding aggregations support: Should async PPL support timefields/histogram? The ppl_async_search_strategy mimics the sql_async_search_strategy, which doesn't have histogram support.

Yes this is what we want as a fast follow, this PR doesn't have workflows where a time field is selected. This is a pre-req for histogram support.

@ananzh ananzh added v2.18.0 and removed v2.19.0 labels Oct 30, 2024
@ananzh ananzh merged commit e1a1b8f into opensearch-project:main Oct 30, 2024
78 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-8706-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e1a1b8f103701666c271252d4bf569e595f5969a
# Push it to GitHub
git push --set-upstream origin backport/backport-8706-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-8706-to-2.x.

ananzh pushed a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Oct 30, 2024
…ch-project#8706)

Backport PR:
opensearch-project#8706

From original PR:
* add support for async ppl to discover

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* Changeset file for PR opensearch-project#8706 created/updated

* update s3_type test to add PPL as supported lang

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* fix lint error

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ananzh added a commit that referenced this pull request Oct 31, 2024
…8769)

Backport PR:
#8706

From original PR:
* add support for async ppl to discover



* Changeset file for PR #8706 created/updated

* update s3_type test to add PPL as supported lang



* fix lint error



---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/OpenSearch-Dashboards that referenced this pull request Nov 1, 2024
* add support for async ppl to discover

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* Changeset file for PR opensearch-project#8706 created/updated

* update s3_type test to add PPL as supported lang

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* fix lint error

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants