-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Prevent wrapping of time fields #8755
Conversation
Signed-off-by: Miki <miki@amazon.com>
❌ Entry Too LongEntry is 103 characters long, which is 3 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8755 +/- ##
=======================================
Coverage 60.75% 60.75%
=======================================
Files 3798 3798
Lines 90685 90685
Branches 14272 14272
=======================================
Hits 55093 55093
Misses 32094 32094
Partials 3498 3498
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* Prevent wrapping of time fields Signed-off-by: Miki <miki@amazon.com> * Changeset file for PR #8755 created/updated --------- Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 056e481) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Prevent wrapping of time fields Signed-off-by: Miki <miki@amazon.com> * Changeset file for PR #8755 created/updated --------- Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 056e481) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Prevent wrapping of time fields * Changeset file for PR #8755 created/updated --------- (cherry picked from commit 056e481) Signed-off-by: Miki <miki@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
* Prevent wrapping of time fields Signed-off-by: Miki <miki@amazon.com> * Changeset file for PR opensearch-project#8755 created/updated --------- Signed-off-by: Miki <miki@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
Prevent wrapping of time fields which causes an overlap when languages are changed in the query editor.
Note: Discover still needs to allow triggering a re-render for a better solution.
Before
Screen.Recording.2024-10-30.at.11.29.36.AM.mp4
After
Screen.Recording.2024-10-30.at.11.30.02.AM.mp4
Changelog
Check List
yarn test:jest
yarn test:jest_integration