Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Prevent wrapping of time fields #8755

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Oct 30, 2024

Description

Prevent wrapping of time fields which causes an overlap when languages are changed in the query editor.

Note: Discover still needs to allow triggering a re-render for a better solution.

Before

Screen.Recording.2024-10-30.at.11.29.36.AM.mp4

After

Screen.Recording.2024-10-30.at.11.30.02.AM.mp4

Changelog

  • fix: Fix time field wrapping overlap on language change in Discover table

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Miki <miki@amazon.com>
Copy link
Contributor

❌ Entry Too Long

Entry is 103 characters long, which is 3 characters longer than the maximum allowed length of 100 characters. Please revise your entry to be within the maximum length.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.75%. Comparing base (e5d665b) to head (b3cf6f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8755   +/-   ##
=======================================
  Coverage   60.75%   60.75%           
=======================================
  Files        3798     3798           
  Lines       90685    90685           
  Branches    14272    14272           
=======================================
  Hits        55093    55093           
  Misses      32094    32094           
  Partials     3498     3498           
Flag Coverage Δ
Linux_1 29.06% <ø> (ø)
Linux_2 56.39% <ø> (ø)
Linux_3 37.60% <ø> (ø)
Linux_4 29.82% <ø> (ø)
Windows_1 29.07% <ø> (ø)
Windows_2 56.34% <ø> (ø)
Windows_3 37.60% <ø> (+<0.01%) ⬆️
Windows_4 29.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMoo-Miki AMoo-Miki merged commit 056e481 into opensearch-project:main Oct 30, 2024
68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 30, 2024
* Prevent wrapping of time fields

Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR #8755 created/updated

---------

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 056e481)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 30, 2024
* Prevent wrapping of time fields

Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR #8755 created/updated

---------

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 056e481)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla pushed a commit that referenced this pull request Oct 30, 2024
* Prevent wrapping of time fields



* Changeset file for PR #8755 created/updated

---------



(cherry picked from commit 056e481)

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/OpenSearch-Dashboards that referenced this pull request Nov 1, 2024
* Prevent wrapping of time fields

Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR opensearch-project#8755 created/updated

---------

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants