-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[augmenter] do not support datasources with no version #8915
[augmenter] do not support datasources with no version #8915
Conversation
… version Do not display if the datasource attached to the index pattern has an empty version. Requires OpenSearch versions. Still working on tests. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8915 +/- ##
==========================================
+ Coverage 60.86% 60.87% +0.01%
==========================================
Files 3802 3802
Lines 91059 91070 +11
Branches 14370 14374 +4
==========================================
+ Hits 55425 55442 +17
+ Misses 32095 32086 -9
- Partials 3539 3542 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 539675e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…earch-project#8915)" This reverts commit 539675e.
Description
Do not display if the datasource attached to the index pattern has a not compatible engine version. In this case we expect
.0
utilizing semver checking by version 1.0.0 should be sufficient to solving this problem since the data source we want to filter returns version.0
which we first released on 1.0.0Issues Resolved
n/a
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration