Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[augmenter] do not support datasources with no version #8915

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Nov 22, 2024

Description

Do not display if the datasource attached to the index pattern has a not compatible engine version. In this case we expect .0 utilizing semver checking by version 1.0.0 should be sufficient to solving this problem since the data source we want to filter returns version .0 which we first released on 1.0.0

Issues Resolved

n/a

Screenshot

Testing the changes

  • unit tests
  • verified on machine pointing to this data source with this version number

Changelog

  • fix: do not support data sources with no version for vis augmenter

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

… version

Do not display if the datasource attached to the index pattern has an empty
version. Requires OpenSearch versions.

Still working on tests.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.87%. Comparing base (c928aec) to head (f391e98).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/plugins/vis_augmenter/public/utils/utils.ts 77.77% 0 Missing and 2 partials ⚠️
src/plugins/vis_augmenter/public/plugin.ts 0.00% 1 Missing ⚠️
...izations/public/embeddable/visualize_embeddable.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8915      +/-   ##
==========================================
+ Coverage   60.86%   60.87%   +0.01%     
==========================================
  Files        3802     3802              
  Lines       91059    91070      +11     
  Branches    14370    14374       +4     
==========================================
+ Hits        55425    55442      +17     
+ Misses      32095    32086       -9     
- Partials     3539     3542       +3     
Flag Coverage Δ
Linux_1 29.02% <66.66%> (+<0.01%) ⬆️
Linux_2 56.39% <ø> (ø)
Linux_3 37.89% <25.00%> (+0.01%) ⬆️
Linux_4 29.00% <ø> (+<0.01%) ⬆️
Windows_1 29.03% <66.66%> (+<0.01%) ⬆️
Windows_2 56.34% <ø> (ø)
Windows_3 37.90% <25.00%> (+0.01%) ⬆️
Windows_4 29.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@joshuali925 joshuali925 merged commit 539675e into opensearch-project:main Nov 22, 2024
69 of 70 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 22, 2024
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 539675e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler added a commit to ohltyler/OpenSearch-Dashboards that referenced this pull request Nov 25, 2024
ohltyler added a commit that referenced this pull request Dec 4, 2024
ArgusLi pushed a commit to ArgusLi/OpenSearch-Dashboards that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants