Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover Test] TestID-69: Filtering. Add data-test-subj tags. #9027

Merged
merged 3 commits into from
Dec 10, 2024
Merged

[Discover Test] TestID-69: Filtering. Add data-test-subj tags. #9027

merged 3 commits into from
Dec 10, 2024

Conversation

ArgusLi
Copy link
Contributor

@ArgusLi ArgusLi commented Dec 10, 2024

Description

Adds data-test-subj tags required for TESTID-69.

Screenshot

Changelog

  • skip

@github-actions github-actions bot added first-time-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Dec 10, 2024
@ArgusLi ArgusLi changed the base branch from cypress-unification to main December 10, 2024 18:59
@ArgusLi ArgusLi force-pushed the testid-69-data-test-subj-additions branch 2 times, most recently from 52e110a to 0a5843a Compare December 10, 2024 19:17
@d-rowe @opensearch-changeset-bot @ArgusLi
Update Cypress to v12 (opensearch-project#8926)
746c715 
* Update cypress to v12

Signed-off-by: Daniel Rowe <rowdane@amazon.com>

* Add required e2e.js

Signed-off-by: Daniel Rowe <rowdane@amazon.com>

* Changeset file for PR opensearch-project#8926 created/updated

* Update license header

Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com>

* Update license in e2e.js

Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com>

---------

Signed-off-by: Daniel Rowe <rowdane@amazon.com>
Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com>
Co-authored-by: Daniel Rowe <rowdane@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
d-rowe and others added 2 commits December 10, 2024 11:18
@d-rowe @opensearch-changeset-bot @ArgusLi
fix: support imports without extensions in cypress webpack build (ope…
3c3e64b 
…nsearch-project#8993)

* fix: support imports without extensions in cypress webpack build

Signed-off-by: Daniel Rowe <rowdane@amazon.com>

* Changeset file for PR opensearch-project#8993 created/updated

* use typescript config

Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com>

* fix lint

Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com>

* disable new test isolation feature

This isolation was causing regressions

Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com>

---------

Signed-off-by: Daniel Rowe <rowdane@amazon.com>
Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@ArgusLi
Add data-test-subj tags.
47ecb97 
Signed-off-by: Argus Li <contactme@chunkeili.com>
@ArgusLi ArgusLi force-pushed the testid-69-data-test-subj-additions branch from 0a5843a to 47ecb97 Compare December 10, 2024 19:18
LDrago27
LDrago27 approved these changes Dec 10, 2024
View reviewed changes
changelogs/fragments/8926.yml Outdated Show resolved Hide resolved
cypress.config.ts Outdated Show resolved Hide resolved
@ananzh ananzh added the v2.19.0 label Dec 10, 2024
@ananzh ananzh merged commit 6a0484a into opensearch-project:main Dec 10, 2024
15 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 10, 2024
@github-actions @d-rowe @opensearch-changeset-bot
[Discover Test] TestID-69: Filtering. Add data-test-subj tags. (#9027)
9abcd18 
* Update Cypress to v12 (#8926)

* Update cypress to v12

Signed-off-by: Daniel Rowe <rowdane@amazon.com>

* Add required e2e.js

Signed-off-by: Daniel Rowe <rowdane@amazon.com>

* Changeset file for PR #8926 created/updated

* Update license header

Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com>

* Update license in e2e.js

Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com>

---------

Signed-off-by: Daniel Rowe <rowdane@amazon.com>
Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com>
Co-authored-by: Daniel Rowe <rowdane@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* fix: support imports without extensions in cypress webpack build (#8993)

* fix: support imports without extensions in cypress webpack build

Signed-off-by: Daniel Rowe <rowdane@amazon.com>

* Changeset file for PR #8993 created/updated

* use typescript config

Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com>

* fix lint

Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com>

* disable new test isolation feature

This isolation was causing regressions

Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com>

---------

Signed-off-by: Daniel Rowe <rowdane@amazon.com>
Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

* Add data-test-subj tags.

Signed-off-by: Argus Li <contactme@chunkeili.com>

---------

Signed-off-by: Daniel Rowe <rowdane@amazon.com>
Signed-off-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com>
Signed-off-by: Argus Li <contactme@chunkeili.com>
Co-authored-by: Daniel Rowe <51932404+d-rowe@users.noreply.github.com>
Co-authored-by: Daniel Rowe <rowdane@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 6a0484a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Dec 10, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.86%. Comparing base (7df73dd) to head (47ecb97).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9027   +/-   ##
=======================================
  Coverage   60.86%   60.86%           
=======================================
  Files        3808     3808           
  Lines       91209    91209           
  Branches    14410    14410           
=======================================
  Hits        55516    55516           
  Misses      32153    32153           
  Partials     3540     3540
Flag Coverage Δ
Linux_1 29.02% <ø> (ø)
Linux_2 56.38% <ø> (ø)
Linux_3 37.93% <100.00%> (ø)
Linux_4 29.01% <ø> (ø)
Windows_1 29.03% <ø> (ø)
Windows_2 56.34% <ø> (ø)
Windows_3 37.94% <100.00%> (+<0.01%) ⬆️
Windows_4 29.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgusLi ArgusLi deleted the testid-69-data-test-subj-additions branch December 10, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@LDrago27 LDrago27 LDrago27 approved these changes

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
backport 2.x first-time-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.19.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArgusLi @LDrago27 @ananzh @d-rowe