-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] Refactored src/plugins/vis_type_tagcloud directory #98
[Rename] Refactored src/plugins/vis_type_tagcloud directory #98
Conversation
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -35,7 +35,7 @@ const prepareDimension = (params: SchemaConfig) => { | |||
}; | |||
|
|||
export const toExpressionAst = (vis: Vis<TagCloudVisParams>, params: BuildPipelineParams) => { | |||
const esaggs = buildExpressionFunction<EsaggsExpressionFunctionDefinition>('esaggs', { | |||
const esaggs = buildExpressionFunction<OpenSearchaggsExpressionFunctionDefinition>('esaggs', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
esaggs --> opensearchaggs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Miss one 'es'. Others look good.
* [Rename] Refactored src/plugins/vis_type_tagcloud directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
* [Rename] Refactored src/plugins/vis_type_tagcloud directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
* [Rename] Refactored src/plugins/vis_type_tagcloud directory Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
…pensearch-project#98) Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
…pensearch-project#98) Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
…pensearch-project#98) Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: Mihir Soni mihirsoni.123@gmail.com
Issue #, if available: #37
Description of changes: Refactored src/plugins/vis_type_tagcloud directory
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.