Add test for createRestRequest

Signed-off-by: Craig Perkins <cwperx@amazon.com>
opensearch-project · Sep 28, 2023 · 104c512 · 104c512
1 parent 0a0214d
commit 104c512
Showing 1 changed file with 16 additions and 0 deletions.
diff --git a/server/src/test/java/org/opensearch/http/AbstractHttpServerTransportTests.java b/server/src/test/java/org/opensearch/http/AbstractHttpServerTransportTests.java
@@ -65,6 +65,7 @@
 
 import java.net.InetSocketAddress;
 import java.net.UnknownHostException;
+import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
@@ -150,6 +151,21 @@ public void testHttpPublishPort() throws Exception {
         }
     }
 
+    public void testCreateRestRequestDoesNotGenerateRequestID() {
+        FakeRestRequest fakeRestRequest = new FakeRestRequest.Builder(NamedXContentRegistry.EMPTY).withContent(
+            new BytesArray("bar".getBytes(StandardCharsets.UTF_8)),
+            null
+        ).withPath("/foo").withHeaders(Collections.singletonMap("Content-Type", Collections.singletonList("text/plain"))).build();
+
+        RestRequest request = AbstractHttpServerTransport.createRestRequest(
+            xContentRegistry(),
+            fakeRestRequest.getHttpRequest(),
+            fakeRestRequest.getHttpChannel()
+        );
+
+        assertEquals("request should not generate id", -1, request.getRequestId());
+    }
+
     public void testDispatchDoesNotModifyThreadContext() {
         final HttpServerTransport.Dispatcher dispatcher = new HttpServerTransport.Dispatcher() {