Remove max limit from cluster.remote_store.index.segment_metadata.ret…

…ention.max_count setting

Signed-off-by: Sachin Kale <kalsac@amazon.com>

server/src/main/java/org/opensearch/indices/recovery/RecoverySettings.java

@@ -165,7 +165,6 @@ public class RecoverySettings {
         "cluster.remote_store.index.segment_metadata.retention.max_count",
         10,
         -1,
-        100,
         v -> {
             if (v == 0) {
                 throw new IllegalArgumentException(

server/src/test/java/org/opensearch/indices/recovery/RecoverySettingsDynamicUpdateTests.java

@@ -113,7 +113,7 @@ public void testSegmentMetadataRetention() {
         );
         assertEquals(-1, recoverySettings.getMinRemoteSegmentMetadataFiles());
 
-        // Setting value > default (10) and value < max (100)
+        // Setting value > default (10)
         clusterSettings.applySettings(
             Settings.builder().put(RecoverySettings.CLUSTER_REMOTE_INDEX_SEGMENT_METADATA_RETENTION_MAX_COUNT_SETTING.getKey(), 15).build()
         );
@@ -140,16 +140,5 @@ public void testSegmentMetadataRetention() {
             )
         );
         assertEquals(15, recoverySettings.getMinRemoteSegmentMetadataFiles());
-
-        // Setting value > 100 should fail and retain the existing value
-        assertThrows(
-            IllegalArgumentException.class,
-            () -> clusterSettings.applySettings(
-                Settings.builder()
-                    .put(RecoverySettings.CLUSTER_REMOTE_INDEX_SEGMENT_METADATA_RETENTION_MAX_COUNT_SETTING.getKey(), 105)
-                    .build()
-            )
-        );
-        assertEquals(15, recoverySettings.getMinRemoteSegmentMetadataFiles());
     }
 }