Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] NodeId in segment and translog metadata file name may contain '-' #10450

Closed
gbbafna opened this issue Oct 6, 2023 · 2 comments · Fixed by #10480
Closed

[Remote Store] NodeId in segment and translog metadata file name may contain '-' #10450

gbbafna opened this issue Oct 6, 2023 · 2 comments · Fixed by #10480
Labels
bug Something isn't working untriaged v2.11.0 Issues and PRs related to version 2.11.0

Comments

@gbbafna
Copy link
Collaborator

gbbafna commented Oct 6, 2023

Coming from #10379 (comment)

Relevant PR : #10229

We have added nodeId in metadata file names in translog and segment . NodeId is base64 UUID which can contain '-' . Tokenizing it using our metadata separator will not work in this case

Solution

  1. Process the nodeId to remove - before adding it to metadata file name .
  2. Change the separator to some other value as done in Updating the separator for RemoteStoreLockManager since underscore is allowed in base64UUID url charset #10379 to ... . In this solution, we will need to handle backward compatibility .
@gbbafna gbbafna added bug Something isn't working untriaged labels Oct 6, 2023
@gbbafna gbbafna changed the title [Remote Store] NodeId in segment and translog metadata file name is base64 UUID can contain '-' [Remote Store] NodeId in segment and translog metadata file name may contain '-' Oct 6, 2023
@gbbafna gbbafna added the v2.11.0 Issues and PRs related to version 2.11.0 label Oct 6, 2023
@rohan19a
Copy link

rohan19a commented Oct 6, 2023

Hi @sejli, I would like to take up this issue as a part of OSCI

@gbbafna
Copy link
Collaborator Author

gbbafna commented Oct 7, 2023

Hi @rohan19a , thanks, I already have a PR since this needs to go in as part of 2.11 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged v2.11.0 Issues and PRs related to version 2.11.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants