Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remote Store] Using hash of node id in metadata file names #10480

Merged
merged 1 commit into from
Oct 7, 2023
Merged

[Remote Store] Using hash of node id in metadata file names #10480

merged 1 commit into from
Oct 7, 2023

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Oct 7, 2023

Description

Using hash of node id in remote segment and translog metadata file names

Related Issues

Resolves #10450

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working v2.11.0 Issues and PRs related to version 2.11.0 labels Oct 7, 2023
@gbbafna gbbafna added backport 2.x Backport to 2.x branch skip-changelog backport 2.11 and removed bug Something isn't working v2.11.0 Issues and PRs related to version 2.11.0 labels Oct 7, 2023
@gbbafna gbbafna marked this pull request as ready for review October 7, 2023 05:11
@gbbafna gbbafna requested a review from msfroh as a code owner October 7, 2023 05:11
@github-actions github-actions bot added bug Something isn't working v2.11.0 Issues and PRs related to version 2.11.0 labels Oct 7, 2023
@gbbafna
Using hash of node id in metadata file names
9129848 
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change 9129848

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Gradle Check (Jenkins) Run Completed with:

ashking94
ashking94 approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, do consider adding the suggested changes.

server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java Show resolved Hide resolved
server/src/test/java/org/opensearch/index/remote/RemoteStoreUtilsTests.java Show resolved Hide resolved
server/src/main/java/org/opensearch/index/translog/transfer/TranslogTransferMetadata.java Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Gradle Check (Jenkins) Run Completed with:

@gbbafna
Copy link
Collaborator Author

gbbafna commented Oct 7, 2023

The failing tests are not related to the above changes. These are failing in other gradle runs as well . Since this is a critical fix for Remote Store, I am going to get this one merged.

org.opensearch.script.expression.MoreExpressionIT.testSpecialValueVariable {p0={"search.concurrent_segment_search.enabled":"true"}}
org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadNonexistentBlobThrowsNoSuchFileException

@gbbafna gbbafna merged commit 98defa5 into opensearch-project:main Oct 7, 2023
13 of 14 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 7, 2023
@github-actions
[Remote Store] Using hash of node id in metadata file names (#10480)
9905642 
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
(cherry picked from commit 98defa5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 7, 2023
Closed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 7, 2023
@github-actions
[Remote Store] Using hash of node id in metadata file names (#10480)
363dc7f 
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
(cherry picked from commit 98defa5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 7, 2023
Closed
ashking94 pushed a commit to ashking94/OpenSearch that referenced this pull request Oct 7, 2023
@gbbafna @ashking94
[Remote Store] Using hash of node id in metadata file names (opensear…
ff7160d 
…ch-project#10480)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@ashking94 ashking94 mentioned this pull request Oct 7, 2023
Merged
ashking94 pushed a commit to ashking94/OpenSearch that referenced this pull request Oct 7, 2023
@gbbafna @ashking94
[Remote Store] Using hash of node id in metadata file names (opensear…
cca4c78 
…ch-project#10480)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@ashking94 ashking94 mentioned this pull request Oct 7, 2023
Merged
gbbafna added a commit that referenced this pull request Oct 7, 2023
@ashking94 @gbbafna
[Backport 2.x] [Remote Store] Using hash of node id in metadata file …
b2a836b 
…names (#10491)

* [Remote Store] Using hash of node id in metadata file names (#10480)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManagerTests (#10490)

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
gbbafna added a commit that referenced this pull request Oct 9, 2023
@ashking94 @gbbafna
[Backport 2.11] [Remote Store] Using hash of node id in metadata file…
38df519 
… names (#10492)

* [Remote Store] Using hash of node id in metadata file names (#10480)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManagerTests (#10490)

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 9, 2023
@gbbafna @deshsidd
[Remote Store] Using hash of node id in metadata file names (opensear…
312c536 
…ch-project#10480)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
@gbbafna @austintlee
[Remote Store] Using hash of node id in metadata file names (opensear…
d595429 
…ch-project#10480)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@gbbafna @shiv0408
[Remote Store] Using hash of node id in metadata file names (opensear…
bb01730 
…ch-project#10480)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashking94 ashking94 ashking94 approved these changes

@sachinpkale sachinpkale sachinpkale approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch backport 2.11 bug Something isn't working skip-changelog v2.11.0 Issues and PRs related to version 2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Remote Store] NodeId in segment and translog metadata file name may contain '-'
3 participants
@gbbafna @sachinpkale @ashking94