Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add groupId value propagation tests for ZIP publication task #4771

Closed
lukas-vlcek opened this issue Oct 13, 2022 · 0 comments · Fixed by #4772
Closed

Add groupId value propagation tests for ZIP publication task #4771

lukas-vlcek opened this issue Oct 13, 2022 · 0 comments · Fixed by #4772
Labels
Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request untriaged

Comments

@lukas-vlcek
Copy link
Contributor

Is your feature request related to a problem? Please describe.

We made it possible to configure the ZIP publication groupId value in #4156 (followed by #4360) and this was back-ported to 2.x branch in #4733.

This change requires some configuration changes in couple of existing plugins. In order to make it more obvious how each plugin should be updated we can implement more tests that verify how the groupId value is inherited/propagated in specific cases.

For example what happens when the group value is defined only in the top level allprojects section. Or what happens when its value is defined on several levels.

Describe the solution you'd like

Adding specific tests to PublishTests.java would be helpful. Should there be any changes in how gradle (or any of its plugins involved in the ZIP publications processing) handles the propagation of the value then these tests can help discover it in advance.

Describe alternatives you've considered

There are no alternatives. The process of plugin configuration and release can only benefit from more automated tests (in this case we can think of the test code as a "living" documentation).

Additional context

There was a discussion on the original PR that led to the idea of adding more tests: #4733 (comment)
@lukas-vlcek lukas-vlcek added enhancement Enhancement or improvement to existing feature or request untriaged labels Oct 13, 2022
lukas-vlcek added a commit to lukas-vlcek/OpenSearch that referenced this issue Oct 13, 2022
@lukas-vlcek
Add groupId value propagation tests for ZIP publication task
a356d8d 
The groupId can be defined on several levels. This commit adds more tests to cover the "edge" cases.

- In one case the groupId is inherited from the top most 'allprojects' section (and thus can be missing in the publications section).
- The other case is opposite, it tests that if the groupId is defined on several levels then the most internal level outweighs the other levels.

Closes: opensearch-project#4771

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
@lukas-vlcek lukas-vlcek mentioned this issue Oct 13, 2022
Merged
6 tasks
lukas-vlcek added a commit to lukas-vlcek/OpenSearch that referenced this issue Oct 13, 2022
@lukas-vlcek
Add groupId value propagation tests for ZIP publication task
9bc7589 
The groupId can be defined on several levels. This commit adds more tests to cover the "edge" cases.

- In one case the groupId is inherited from the top most 'allprojects' section (and thus can be missing in the publications section).
- The other case is opposite, it tests that if the groupId is defined on several levels then the most internal level outweighs the other levels.

Closes: opensearch-project#4771

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
lukas-vlcek added a commit to lukas-vlcek/OpenSearch that referenced this issue Oct 13, 2022
@lukas-vlcek
Add groupId value propagation tests for ZIP publication task
505a1fa 
The groupId can be defined on several levels. This commit adds more tests to cover the "edge" cases.

- In one case the groupId is inherited from the top most 'allprojects' section (and thus can be missing in the publications section).
- The other case is opposite, it tests that if the groupId is defined on several levels then the most internal level outweighs the other levels.

Closes: opensearch-project#4771

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
lukas-vlcek added a commit to lukas-vlcek/OpenSearch that referenced this issue Oct 14, 2022
@lukas-vlcek
Add groupId value propagation tests for ZIP publication task
be0cb20 
The groupId can be defined on several levels. This commit adds more tests to cover the "edge" cases.

- In one case the groupId is inherited from the top most 'allprojects' section (and thus can be missing in the publications section).
- The other case is opposite, it tests that if the groupId is defined on several levels then the most internal level outweighs the other levels.

Closes: opensearch-project#4771

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
lukas-vlcek added a commit to lukas-vlcek/OpenSearch that referenced this issue Oct 14, 2022
@lukas-vlcek
Add groupId value propagation tests for ZIP publication task
5f6e041 
The groupId can be defined on several levels. This commit adds more tests to cover the "edge" cases.

- In one case the groupId is inherited from the top most 'allprojects' section (and thus can be missing in the publications section).
- The other case is opposite, it tests that if the groupId is defined on several levels then the most internal level outweighs the other levels.

Closes: opensearch-project#4771

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
reta pushed a commit that referenced this issue Oct 19, 2022
@lukas-vlcek
Add groupId value propagation tests for ZIP publication task (#4772)
eb33015 
The groupId can be defined on several levels. This commit adds more tests to cover the "edge" cases.

- In one case the groupId is inherited from the top most 'allprojects' section (and thus can be missing in the publications section).
- The other case is opposite, it tests that if the groupId is defined on several levels then the most internal level outweighs the other levels.

Closes: #4771

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
ashking94 pushed a commit to ashking94/OpenSearch that referenced this issue Nov 7, 2022
@lukas-vlcek @ashking94
Add groupId value propagation tests for ZIP publication task (opensea…
52cca52 
…rch-project#4772)

The groupId can be defined on several levels. This commit adds more tests to cover the "edge" cases.

- In one case the groupId is inherited from the top most 'allprojects' section (and thus can be missing in the publications section).
- The other case is opposite, it tests that if the groupId is defined on several levels then the most internal level outweighs the other levels.

Closes: opensearch-project#4771

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>

Signed-off-by: Lukáš Vlček <lukas.vlcek@aiven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add groupId value propagation tests for ZIP publication task lukas-vlcek/OpenSearch
2 participants
@lukas-vlcek @mch2