[Tracing Instrumentation] Add instrumentation in InboundHandler #10143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gaganjuneja
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
peternied,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
VachaShah,
dbwiddis,
sachinpkale,
sohami and
msfroh
as code owners
github-actions
bot
added
distributed framework
enhancement
6 tasks
|
@reta, Please take a look. Thanks! |
Compatibility status:Checks if related components are compatible with change f13dc76 Incompatible componentsIncompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Gradle Check (Jenkins) Run Completed with:
|
reta
reviewed
Oct 4, 2023
server/src/main/java/org/opensearch/transport/InboundHandler.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Oct 4, 2023
server/src/main/java/org/opensearch/telemetry/tracing/channels/TraceableTransportChannel.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Oct 4, 2023
server/src/main/java/org/opensearch/telemetry/tracing/channels/TraceableTransportChannel.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
reta
reviewed
Oct 4, 2023
server/src/main/java/org/opensearch/transport/RequestHandlerRegistry.java
Show resolved
Hide resolved
reta
reviewed
Oct 4, 2023
server/src/main/java/org/opensearch/transport/TcpTransportChannel.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Oct 4, 2023
...er/src/main/java/org/opensearch/telemetry/tracing/channels/TraceableTcpTransportChannel.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
reta
reviewed
Oct 4, 2023
...er/src/main/java/org/opensearch/telemetry/tracing/channels/TraceableTcpTransportChannel.java
Outdated
Show resolved
Hide resolved
reta
reviewed
Oct 4, 2023
...er/src/main/java/org/opensearch/telemetry/tracing/channels/TraceableTcpTransportChannel.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gagan Juneja <gjjuneja@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
reta
approved these changes
Oct 4, 2023
Gradle Check (Jenkins) Run Completed with:
|
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
* Add instrumentation in InboundHandler Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add CHANGELOG Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> (cherry picked from commit aac0f09) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
FYI @Gaganjuneja & @reta This is a breaking change impacting the security plugin and performance-analyzer. Can you help mitigate the build failures associated with this change? |
|
@peternied absolutely, I will take care of it tomorrow morning, thank you |
reta
pushed a commit
that referenced
this pull request
Oct 5, 2023
…) (#10381) * Add instrumentation in InboundHandler * Add CHANGELOG * Address review comment * Address review comment * Address review comment * Empty-Commit * Address review comment * Address review comment * Address review comment --------- (cherry picked from commit aac0f09) Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
|
I ran a search for
|
deshsidd
pushed a commit
to deshsidd/OpenSearch
that referenced
this pull request
Oct 9, 2023
…search-project#10143) * Add instrumentation in InboundHandler Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add CHANGELOG Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
vikasvb90
pushed a commit
to vikasvb90/OpenSearch
that referenced
this pull request
Oct 10, 2023
…search-project#10143) * Add instrumentation in InboundHandler Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add CHANGELOG Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…search-project#10143) * Add instrumentation in InboundHandler Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Add CHANGELOG Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Empty-Commit Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> * Address review comment Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> --------- Signed-off-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Gagan Juneja <gagandeepjuneja@gmail.com> Co-authored-by: Gagan Juneja <gjjuneja@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add instrumentation in InboundHandler class so that it's generically available to all the actions.
Related Issues
Resolves #10095
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.