Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Search latency tracking - Coordinator node #10279

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

sgup432
Copy link
Contributor

@sgup432 sgup432 commented Sep 29, 2023

Description

Changing version guards to 2.11
Backport #8386

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

We are trying to add search stats to coordinator level node stats. This keeps track of the total time, current requests, and total requests of each request phase.

Also added support for general coordinator stats as well on the node level.

Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
Signed-off-by: sahil <61558528+buddharajusahil@users.noreply.github.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com>
Co-authored-by: sahil buddharaju <sahilbud@amazon.com>
Co-authored-by: Sagar Upadhyaya <upasagar@amazon.com>
Co-authored-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Co-authored-by: Sagar <99425694+sgup432@users.noreply.github.com>
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
@sgup432
Copy link
Contributor Author

sgup432 commented Sep 29, 2023

@msfroh Need help with this. Will update main branch too with 2.11

@msfroh
Copy link
Collaborator

msfroh commented Sep 29, 2023

@sgup432 Can you prepare the PR for main with the updated version checks?

That way we can merge it as soon as possible after this one.

@sgup432
Copy link
Contributor Author

sgup432 commented Sep 29, 2023

@msfroh PR on main branch - https://github.com/opensearch-project/OpenSearch/pull/10280/files

@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change eb432f3

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #10279 (eb432f3) into 2.x (eaccdf5) will increase coverage by 0.03%.
Report is 2 commits behind head on 2.x.
The diff coverage is 80.25%.

@@             Coverage Diff              @@
##                2.x   #10279      +/-   ##
============================================
+ Coverage     70.87%   70.91%   +0.03%     
- Complexity    58344    58356      +12     
============================================
  Files          4814     4816       +2     
  Lines        275527   275739     +212     
  Branches      40503    40531      +28     
============================================
+ Hits         195280   195529     +249     
+ Misses        63613    63487     -126     
- Partials      16634    16723      +89     
Files Coverage Δ
...main/java/org/opensearch/core/rest/RestStatus.java 97.33% <100.00%> (+8.14%) ⬆️
...arch/analysis/common/MappingCharFilterFactory.java 50.00% <100.00%> (ø)
...earch/action/search/AbstractSearchAsyncAction.java 79.05% <100.00%> (+1.43%) ⬆️
...ch/action/search/CanMatchPreFilterSearchPhase.java 93.44% <ø> (-3.28%) ⬇️
...ion/search/SearchDfsQueryThenFetchAsyncAction.java 100.00% <100.00%> (+4.76%) ⬆️
...java/org/opensearch/action/search/SearchPhase.java 100.00% <100.00%> (+20.00%) ⬆️
...g/opensearch/action/search/SearchPhaseContext.java 66.66% <ø> (ø)
.../org/opensearch/action/search/SearchPhaseName.java 100.00% <100.00%> (ø)
...action/search/SearchQueryThenFetchAsyncAction.java 88.09% <100.00%> (-2.15%) ⬇️
...g/opensearch/action/search/SearchRequestStats.java 100.00% <100.00%> (ø)
... and 14 more

... and 467 files with indirect coverage changes

@msfroh msfroh merged commit befcde9 into opensearch-project:2.x Sep 29, 2023
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants