-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Search latency tracking - Coordinator node #10279
Conversation
We are trying to add search stats to coordinator level node stats. This keeps track of the total time, current requests, and total requests of each request phase. Also added support for general coordinator stats as well on the node level. Signed-off-by: sahil buddharaju <sahilbud@amazon.com> Signed-off-by: sahil <61558528+buddharajusahil@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com> Co-authored-by: sahil buddharaju <sahilbud@amazon.com> Co-authored-by: Sagar Upadhyaya <upasagar@amazon.com> Co-authored-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> Co-authored-by: Sagar <99425694+sgup432@users.noreply.github.com> Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
@msfroh Need help with this. Will update main branch too with 2.11 |
@sgup432 Can you prepare the PR for main with the updated version checks? That way we can merge it as soon as possible after this one. |
@msfroh PR on main branch - https://github.com/opensearch-project/OpenSearch/pull/10280/files |
Compatibility status:Checks if related components are compatible with change eb432f3 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git] |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #10279 +/- ##
============================================
+ Coverage 70.87% 70.91% +0.03%
- Complexity 58344 58356 +12
============================================
Files 4814 4816 +2
Lines 275527 275739 +212
Branches 40503 40531 +28
============================================
+ Hits 195280 195529 +249
+ Misses 63613 63487 -126
- Partials 16634 16723 +89
|
Description
Changing version guards to 2.11
Backport #8386
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.